I've added the patch to my working copy here, and the installation seemed to complete ok, but I ran into a couple of problems with this using Tomcat 7.0.2 on my Mac. The EJB lookup didn't work for me, and then once I had installed the Java agent, Tomcat refused to start with this exception:
java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.catalina.startup.Bootstrap.load(Bootstrap.java:260) at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:414) Caused by: java.lang.NoClassDefFoundError: org/apache/catalina/ServerFactory at org.apache.openejb.tomcat.loader.OpenEJBListener.findOpenEjbWar(OpenEJBListener.java:77) at org.apache.openejb.tomcat.loader.OpenEJBListener.lifecycleEvent(OpenEJBListener.java:59) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119) at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:89) at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:313) at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:293) at org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:97) at org.apache.catalina.startup.Catalina.load(Catalina.java:537) at org.apache.catalina.startup.Catalina.load(Catalina.java:560) ... 6 more Caused by: java.lang.ClassNotFoundException: org.apache.catalina.ServerFactory at java.net.URLClassLoader$1.run(URLClassLoader.java:202) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:190) at java.lang.ClassLoader.loadClass(ClassLoader.java:307) at java.lang.ClassLoader.loadClass(ClassLoader.java:248) ... 15 more At first glance it looks to me like the Tomcat 7 API had changed, and we probably just need to adapt some of our code to cope with it. I'll carry on having a look at this tomorrow, but please let me know if I've missed something obvious. Cheers Jon On Tue, Oct 12, 2010 at 11:48 PM, Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Hi Matthias > > Thanks for the patch, I'll take a look and get it committed. > > Jon > > On Tue, Oct 12, 2010 at 5:27 PM, Matthias Wessendorf <mat...@apache.org>wrote: > >> On Mon, Oct 11, 2010 at 11:54 PM, David Blevins <david.blev...@visi.com> >> wrote: >> > >> > On Oct 11, 2010, at 12:11 PM, Matthias Wessendorf wrote: >> > >> >> hello, >> >> >> >> what it is Tomcat 7 version that is supposed to work with OpenEJB 3.2 >> SNAPSHOT ? >> >> >> >> The WAR from [1] does not work on 7.0.2. >> >> >> >> I reopened [2]. >> > >> > I haven't tried Tomcat 7 yet myself, but that's the version we'll need >> to certify Web Profile. Someone recently posted an error that looked like >> there was no longer a lib directory for us to put jars in. >> >> >> na, that's wrong . see OPENEJB-1367 >> >> > >> > If you're interested in digging in, I have a standing offer to get on >> skype and fork over any info I have to anyone who'd like to help. >> > >> > >> > -David >> > >> >> >> >> [1] >> https://repository.apache.org/content/repositories/snapshots/org/apache/openejb/openejb-webapp/3.2-SNAPSHOT/ >> >> [2] https://issues.apache.org/jira/browse/OPENEJB-1261 >> >> >> >> -- >> >> Matthias Wessendorf >> >> >> >> blog: http://matthiaswessendorf.wordpress.com/ >> >> sessions: http://www.slideshare.net/mwessendorf >> >> twitter: http://twitter.com/mwessendorf >> >> >> > >> > >> >> >> >> -- >> Matthias Wessendorf >> >> blog: http://matthiaswessendorf.wordpress.com/ >> sessions: http://www.slideshare.net/mwessendorf >> twitter: http://twitter.com/mwessendorf >> > >
