On Tue, Apr 12, 2011 at 9:55 AM, David Blevins <david.blev...@gmail.com>wrote:
> Thanks, Ivan. > > I did for a brief moment take a look at them. I noticed one of the changes > was to always have a non-null List for parameters in MethodInfo (or a > similar Info). > > I don't recall and this is something I should have written down if true, > but I think some code was relying on that being null in the situations where > no parameters were listed in the xml. The impact being if there are to > attributes for the "same" method, the one with a null parameter list loses > as it's considered more general (i.e. it applies to all methods of a name) > and the other one refers to a specific signature. > David, you are right. Ivan pointed out that there's a statement in Spec 18.2.5.3 which describes a scenario like that above. I double checked the code then uploaded a new patch to OPENEJB-1515 to fix this issue. > > I *thought* we had tests for that, but maybe the aren't as good as I > remember. > > Didn't have time to dig into any of that, though. > > > -David > > On Apr 12, 2011, at 2:24 AM, Ivan wrote: > > > I will check those JIRA soon. > > > > 2011/4/11 Shawn Jiang <genspr...@gmail.com> > > > >> https://issues.apache.org/jira/browse/OPENEJB-1515 > >> > >> There are two patch, the first one is to add a NPE protection. The > >> second > >> one is to address the root cause of this kind of NPE issues. > >> > >> https://issues.apache.org/jira/browse/OPENEJB-1516 > >> > >> When there's no timeout method but there's schedule info for methods in > EJB > >> either from annotation or DD. The > >> org.apache.openejb.core.timer.TimerServiceWrapper.getTimerService() will > >> always throw IllegalStateException. It's obviously wrong. > >> > >> https://issues.apache.org/jira/browse/OPENEJB-1518 > >> > >> Currently, the schedule expression for DayOfMonth list only cover > single > >> day and simple range cases. WeekDay, day to last, Last are all valid > >> items for DayOfMonth values. we need to support them as below: > >> > >> 1, WeekDay style: "2nd mon, 3rd wed,1st sun" > >> 2, day to last style: "-3,-5" > >> 3, Last as element: "4, last" > >> > >> > >> > >> On Sun, Apr 10, 2011 at 10:44 PM, Shawn Jiang <genspr...@gmail.com> > wrote: > >> > >>> All of these Jiras are related to timer in openejb 4.0-SNAPSHOT. > >>> > >>> -- > >>> Shawn > >>> > >> > >> > >> > >> -- > >> Shawn > >> > > > > > > > > -- > > Ivan > > -- Shawn
