Hi Andy, can you explain in 2 words this commit please?
i don't really get the need of it - Romain ---------- Forwarded message ---------- From: <andygumbre...@apache.org> Date: 2012/8/3 Subject: svn commit: r1368815 - in /openejb/trunk/openejb/container/openejb-core: ./ src/main/java/org/apache/openejb/resource/jdbc/dbcp/ src/main/java/org/apache/openejb/resource/jdbc/plugin/ src/test/java/org/apache/openejb/assembler/classic/ To: comm...@openejb.apache.org Author: andygumbrecht Date: Fri Aug 3 07:44:53 2012 New Revision: 1368815 URL: http://svn.apache.org/viewvc?rev=1368815&view=rev Log: Change field in test. Modified: openejb/trunk/openejb/container/openejb-core/pom.xml openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/resource/jdbc/dbcp/JMXBasicDataSource.java openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/resource/jdbc/plugin/DataSourcePlugin.java openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/assembler/classic/DataSourceDefinitionPlaceHolderTest.java Modified: openejb/trunk/openejb/container/openejb-core/pom.xml URL: http://svn.apache.org/viewvc/openejb/trunk/openejb/container/openejb-core/pom.xml?rev=1368815&r1=1368814&r2=1368815&view=diff ============================================================================== --- openejb/trunk/openejb/container/openejb-core/pom.xml (original) +++ openejb/trunk/openejb/container/openejb-core/pom.xml Fri Aug 3 07:44:53 2012 @@ -444,7 +444,6 @@ <version>${project.version}</version> <scope>test</scope> </dependency> - <dependency> <groupId>commons-cli</groupId> <artifactId>commons-cli</artifactId> @@ -610,7 +609,7 @@ <groupId>org.fusesource.jansi</groupId> <artifactId>jansi</artifactId> <version>1.8</version> - </dependency> + </dependency> </dependencies> <profiles> <profile> Modified: openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/resource/jdbc/dbcp/JMXBasicDataSource.java URL: http://svn.apache.org/viewvc/openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/resource/jdbc/dbcp/JMXBasicDataSource.java?rev=1368815&r1=1368814&r2=1368815&view=diff ============================================================================== --- openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/resource/jdbc/dbcp/JMXBasicDataSource.java (original) +++ openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/resource/jdbc/dbcp/JMXBasicDataSource.java Fri Aug 3 07:44:53 2012 @@ -28,6 +28,7 @@ import org.apache.openejb.monitoring.Loc import org.apache.openejb.monitoring.ObjectNameBuilder; // @MBean: don't put it since it is not a pojo +@SuppressWarnings("UnusedDeclaration") @Description("describe a datasource pool") public class JMXBasicDataSource { private transient final org.apache.commons.dbcp.BasicDataSource ds; Modified: openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/resource/jdbc/plugin/DataSourcePlugin.java URL: http://svn.apache.org/viewvc/openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/resource/jdbc/plugin/DataSourcePlugin.java?rev=1368815&r1=1368814&r2=1368815&view=diff ============================================================================== --- openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/resource/jdbc/plugin/DataSourcePlugin.java (original) +++ openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/resource/jdbc/plugin/DataSourcePlugin.java Fri Aug 3 07:44:53 2012 @@ -17,6 +17,7 @@ package org.apache.openejb.resource.jdbc.plugin; public interface DataSourcePlugin { + String updatedUrl(String dataSourceUrl); boolean enableUserDirHack(); Modified: openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/assembler/classic/DataSourceDefinitionPlaceHolderTest.java URL: http://svn.apache.org/viewvc/openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/assembler/classic/DataSourceDefinitionPlaceHolderTest.java?rev=1368815&r1=1368814&r2=1368815&view=diff ============================================================================== --- openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/assembler/classic/DataSourceDefinitionPlaceHolderTest.java (original) +++ openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/assembler/classic/DataSourceDefinitionPlaceHolderTest.java Fri Aug 3 07:44:53 2012 @@ -67,8 +67,10 @@ public class DataSourceDefinitionPlaceHo password = "${pwd}", url = "${url}" ) + @Singleton public static class DSBean { + @SuppressWarnings("SpringJavaAutowiringInspection") @Resource(name = "java:comp/env/superDS") private DataSource ds;
