Hi Andy, thought there was already a buffer in GZip impl
did you bench a bit? on my little sample the difference was not that much important any other results? Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau ---------- Forwarded message ---------- From: <[email protected]> Date: 2012/11/29 Subject: svn commit: r1415122 - in /openejb/trunk/openejb/server/openejb-ejbd/src/main/java/org/apache/openejb/server/ejbd: EjbDaemon.java KeepAliveServer.java To: [email protected] Author: andygumbrecht Date: Thu Nov 29 11:07:27 2012 New Revision: 1415122 URL: http://svn.apache.org/viewvc?rev=1415122&view=rev Log: Still use buffered streams for gzip. Modified: openejb/trunk/openejb/server/openejb-ejbd/src/main/java/org/apache/openejb/server/ejbd/EjbDaemon.java openejb/trunk/openejb/server/openejb-ejbd/src/main/java/org/apache/openejb/server/ejbd/KeepAliveServer.java Modified: openejb/trunk/openejb/server/openejb-ejbd/src/main/java/org/apache/openejb/server/ejbd/EjbDaemon.java URL: http://svn.apache.org/viewvc/openejb/trunk/openejb/server/openejb-ejbd/src/main/java/org/apache/openejb/server/ejbd/EjbDaemon.java?rev=1415122&r1=1415121&r2=1415122&view=diff ============================================================================== --- openejb/trunk/openejb/server/openejb-ejbd/src/main/java/org/apache/openejb/server/ejbd/EjbDaemon.java (original) +++ openejb/trunk/openejb/server/openejb-ejbd/src/main/java/org/apache/openejb/server/ejbd/EjbDaemon.java Thu Nov 29 11:07:27 2012 @@ -30,6 +30,8 @@ import org.apache.openejb.spi.ContainerS import org.apache.openejb.util.LogCategory; import org.apache.openejb.util.Logger; +import java.io.BufferedInputStream; +import java.io.BufferedOutputStream; import java.io.IOException; import java.io.InputStream; import java.io.ObjectInputStream; @@ -97,11 +99,11 @@ public class EjbDaemon implements org.ap return; } - in = socket.getInputStream(); - out = socket.getOutputStream(); + in = new BufferedInputStream(socket.getInputStream()); + out = new BufferedOutputStream(socket.getOutputStream()); if (gzip) { - in = new GZIPInputStream(socket.getInputStream()); - out = new FlushableGZIPOutputStream(socket.getOutputStream()); + in = new GZIPInputStream(new BufferedInputStream(socket.getInputStream())); + out = new BufferedOutputStream(new FlushableGZIPOutputStream(socket.getOutputStream())); } service(in, out); Modified: openejb/trunk/openejb/server/openejb-ejbd/src/main/java/org/apache/openejb/server/ejbd/KeepAliveServer.java URL: http://svn.apache.org/viewvc/openejb/trunk/openejb/server/openejb-ejbd/src/main/java/org/apache/openejb/server/ejbd/KeepAliveServer.java?rev=1415122&r1=1415121&r2=1415122&view=diff ============================================================================== --- openejb/trunk/openejb/server/openejb-ejbd/src/main/java/org/apache/openejb/server/ejbd/KeepAliveServer.java (original) +++ openejb/trunk/openejb/server/openejb-ejbd/src/main/java/org/apache/openejb/server/ejbd/KeepAliveServer.java Thu Nov 29 11:07:27 2012 @@ -210,8 +210,8 @@ public class KeepAliveServer implements in = new BufferedInputStream(socket.getInputStream()); out = new BufferedOutputStream(socket.getOutputStream()); } else { - in = new GZIPInputStream(socket.getInputStream()); - out = new FlushableGZIPOutputStream(socket.getOutputStream()); + in = new GZIPInputStream(new BufferedInputStream(socket.getInputStream())); + out = new BufferedOutputStream(new FlushableGZIPOutputStream(socket.getOutputStream())); } while (running.get()) {
