Hi guys, this messages were IMO too much: why was it log once by pu + why error -> we should check if entities are already enhanced or not if we want to keep error IMO
please shout if you don't agree with this change Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau ---------- Forwarded message ---------- From: <rmannibu...@apache.org> Date: 2012/12/17 Subject: svn commit: r1422918 - /openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java To: comm...@openejb.apache.org Author: rmannibucau Date: Mon Dec 17 13:04:30 2012 New Revision: 1422918 URL: http://svn.apache.org/viewvc?rev=1422918&view=rev Log: when the javaagent is not here error is probably too much (it should often work in particular is entities are enhanced) + no need to log it as much as persistence unit number Modified: openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java Modified: openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java URL: http://svn.apache.org/viewvc/openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java?rev=1422918&r1=1422917&r2=1422918&view=diff ============================================================================== --- openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java (original) +++ openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java Mon Dec 17 13:04:30 2012 @@ -2133,6 +2133,8 @@ public class Assembler extends Assembler } private static class PersistenceClassLoaderHandlerImpl implements PersistenceClassLoaderHandler { + private static boolean logged = false; + private final Map<String, List<ClassFileTransformer>> transformers = new TreeMap<String, List<ClassFileTransformer>>(); @Override @@ -2149,8 +2151,9 @@ public class Assembler extends Assembler } transformers.add(classFileTransformer); } - } else { - logger.error("assembler.noAgent"); + } else if (!logged) { + logger.warning("assembler.noAgent"); + logged = true; } }
