[
https://issues.apache.org/jira/browse/OPENJPA-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564339#action_12564339
]
Christiaan commented on OPENJPA-407:
------------------------------------
I making this remark since I was triggered by the "I changed the 'sql' local
variable in SelectImpl.execute() to be a member variable". I've seen a similar
approach in RowImpl and as described in OPENJPA-474, I think this causes a lot
of memory overhead when a many similar objects and modifications are involved,
since the same sql is duplicated. Of course it is a good thing to cache for
performance, but I do think a cache should use memory if it is available (not
leading to an OoM) or at least try to keep it to a minimum. Not sure if it is
the case with this patch, I just thought of making you aware of it.
regards,
Christiaan
> Cache SQL (or closer precursors to SQL) more aggressively
> ---------------------------------------------------------
>
> Key: OPENJPA-407
> URL: https://issues.apache.org/jira/browse/OPENJPA-407
> Project: OpenJPA
> Issue Type: Improvement
> Components: jdbc, kernel, query, sql
> Affects Versions: 0.9.0, 0.9.6, 0.9.7, 1.0.0
> Reporter: Patrick Linskey
> Fix For: 1.1.0
>
> Attachments: findBy.patch, OPENJPA-407.patch
>
>
> When data is not available in the data cache, OpenJPA dynamically creates SQL
> to look up the requested data. OpenJPA should more aggressively cache this
> SQL to accelerate pathways from a cache miss to the database.
> The generated SQL takes a number of factors into account, including the
> requested records, transaction status, currently-loaded data, and the current
> fetch configuration. Any caching would need to account for these factors as
> well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
