FTR, I made these changes when submitting the patch earlier this morning.

-Patrick

On Apr 22, 2008, at 10:37 AM, Abe White (JIRA) wrote:


[ https://issues.apache.org/jira/browse/OPENJPA-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591381 #action_12591381 ]

Abe White commented on OPENJPA-536:
-----------------------------------

Latest patch looks pretty good.  Two minor details:
1. The class should just be InheritanceOrderMetaDataList, not InheritanceOrderMetaDataList<ClassMetaData>. 2. You don't need all the "if (buffer != null)" checks. buffer is never null. In fact you could make it final.

getMetaData() causes OutOfMemoryError under some cases
------------------------------------------------------

               Key: OPENJPA-536
               URL: https://issues.apache.org/jira/browse/OPENJPA-536
           Project: OpenJPA
        Issue Type: Bug
        Components: jpa
  Affects Versions: 1.0.2, 1.0.3
       Environment: Sun JDK 5
          Reporter: Amy Yang
          Priority: Blocker
           Fix For: 1.1.0

Attachments: 364202.patch, InheritanceComparator.diff, meta_testcase.zip, MetaDataRepository.diff, OPENJPA-536.patch, OPENJPA-536.patch, OPENJPA-536.patch, OPENJPA-536.patch, OPENJPA-536.patch, OPENJPA-536.patch, OPENJPA-536.patch, OPENJPA-536.patch


There are 3 classes: Item, Artist and Person. Artist extends Person.
Invoking JPAFacadeHelper.getMetaData(emf, Item.class) will cause OutOfMemoryError thrown by org.apache.openjpa.meta.MetaDataRepository.processBuffer().

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


--
Patrick Linskey
202 669 5907




Reply via email to