[ 
https://issues.apache.org/jira/browse/OPENJPA-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiaoqin Feng updated OPENJPA-722:
---------------------------------

    Attachment: TestEntityManagerClear-V2.java

Here is the updated tests. I have added new-clear-merge, update-clear-merge and 
delete-clear-merge tests.
I think the expected behavior for em.clear() is just detach, it shouldn't  
flush for all new, updated, delete objects.
Instead it should keep PCState during detachment and are able to merge it back 
and flush/commit correctly after that.

I am also working on this issue. Now still need a bit more work to make delete 
case work.

> persist - clear - merge scenario doesn't work
> ---------------------------------------------
>
>                 Key: OPENJPA-722
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-722
>             Project: OpenJPA
>          Issue Type: Sub-task
>          Components: kernel
>    Affects Versions: 1.0.3, 1.1.0, 1.2.0
>            Reporter: Xiaoqin Feng
>            Assignee: Jeremy Bauer
>         Attachments: TestEntityManagerClear-V2.java, 
> TestEntityManagerClear.java
>
>
> EntityManager.clear() now don't  flush new object but only detach it.
> But DetachManager still flush dirty object and assume detached objects are in 
> clean state.
> When the "new" object is merged back and transaction commit,  because the 
> object state lost its original state PNEW, it will not be added to insert 
> list  and not flushed to DB.
> According to the EntityManager.clear() API,  changes made to entities that 
> have not been flushed to the database will not be persisted.  When they 
> merges back to persistent context, they all should kept there original state.
> I added the following test to 
> org.apache.openjpa.persistence.simple.TestEntityManagerClear.
>     public void testClearMerge() {
>         // Create EntityManager and Start a transaction (1)
>         begin();
>         // Insert a new object then clear persistent context
>         AllFieldTypes testObject1 = new AllFieldTypes();
>         testObject1.setStringField("my test object1");
>         persist(testObject1);
>         //Object1 is not flushed to DB but only detached by clear().
>         em.clear();
>         em.merge(testObject1);
>         //expect the PCState is same as before detached, 
>         //so it is PNew instead of PCLEAN and is add to insert list.
>         commit();
>         
>         //Start a new transaction
>         begin();
>         
>         // Attempt retrieve of Object1 from previous PC (should exist)
>         assertEquals(1, query("select x from AllFieldTypes x "
>             + "where x.stringField = 'my test object1'").
>                 getResultList().size());
>         
>         // Rollback the transaction and close everything
>         rollback();
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to