Hi Pinaki, do you have any unit tests for this change? On Mon, Nov 10, 2008 at 3:35 PM, <[EMAIL PROTECTED]> wrote:
> Author: ppoddar > Date: Mon Nov 10 13:35:35 2008 > New Revision: 712842 > > URL: http://svn.apache.org/viewvc?rev=712842&view=rev > Log: > OPENJPA-764: Parse IN expressions with string functions such as UPPER() > > Modified: > > > openjpa/trunk/openjpa-kernel/src/main/jjtree/org/apache/openjpa/kernel/jpql/JPQL.jjt > > Modified: > openjpa/trunk/openjpa-kernel/src/main/jjtree/org/apache/openjpa/kernel/jpql/JPQL.jjt > URL: > http://svn.apache.org/viewvc/openjpa/trunk/openjpa-kernel/src/main/jjtree/org/apache/openjpa/kernel/jpql/JPQL.jjt?rev=712842&r1=712841&r2=712842&view=diff > > ============================================================================== > --- > openjpa/trunk/openjpa-kernel/src/main/jjtree/org/apache/openjpa/kernel/jpql/JPQL.jjt > (original) > +++ > openjpa/trunk/openjpa-kernel/src/main/jjtree/org/apache/openjpa/kernel/jpql/JPQL.jjt > Mon Nov 10 13:35:35 2008 > @@ -705,7 +705,7 @@ > > void in_expression() #IN : { } > { > - path() [ LOOKAHEAD(1) <NOT> { jjtThis.not = true; }] <IN> > + (path() | scalar_function()) [ LOOKAHEAD(1) <NOT> { jjtThis.not = > true; }] <IN> > "(" (literal_or_param() > (<COMMA> (literal_or_param()))* | subquery()) > ")" > > >
