-1 The extra build time expense is much too high. I've borrowed code from the excluded tests on occasion, so purging them wouldn't be a good solution either, IMO.
-Jeremy On Fri, Feb 20, 2009 at 1:53 PM, Michael Dick (JIRA) <[email protected]>wrote: > > [ > https://issues.apache.org/jira/browse/OPENJPA-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675454#action_12675454] > > Michael Dick commented on OPENJPA-770: > -------------------------------------- > > I didn't realize the test exclusions would add that much time. I vote for > leaving well enough alone - spending an additional 40 -50 minutes per build > with no tangible benefit doesn't sound good to me. > > I appreciate the patch, and I would like to get rid of the long list of > exclusions, but not at that price. > > > Use annotations instead of excluding tests in pom.xml > > ----------------------------------------------------- > > > > Key: OPENJPA-770 > > URL: https://issues.apache.org/jira/browse/OPENJPA-770 > > Project: OpenJPA > > Issue Type: Sub-task > > Affects Versions: 2.0.0 > > Reporter: Michael Dick > > Assignee: Tim McConnell > > Fix For: 2.0.0 > > > > Attachments: OPENJPA-770-2.patch, OPENJPA-770-3.patch, > OPENJPA-770.patch > > > > Original Estimate: 3h > > Remaining Estimate: 3h > > > > In openjpa-persistence-jdbc/pom.xml there are a lot of excluded > testcases. Instead of hard coding these in pom.xml we should use the new > annotation that Pinaki introduced in the "parent" JIRA issue. > > The list of excluded tests can be found in pom.xml, here's a subsection > of them > > <!-- exclude new tests that aren't passing yet --> > > > <exclude>org/apache/openjpa/persistence/jpql/clauses/TestEJBQueryInterface.java</exclude> > > > <exclude>org/apache/openjpa/persistence/kernel/TestInitialValueFetching.java</exclude> > > > <exclude>org/apache/openjpa/persistence/kernel/TestOpenResultsCommit.java</exclude> > > > <exclude>org/apache/openjpa/persistence/query/TestQuotedNumbersInFilters2.java</exclude> > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > >
