[
https://issues.apache.org/jira/browse/OPENJPA-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700293#action_12700293
]
Jeremy Bauer commented on OPENJPA-932:
--------------------------------------
Rick - I applied this patch and have a few comments/issues.
- I'm OK with loading an additional jar to the test classpath in the
openjpa-persistence sub-project since there are very few tests that run in that
package. The code is only testing a warning path and shouldn't affect the
behavior of those tests.
- I could not force the production of the new warning message using the
provided code (which I think is the intent of bad-persistence.xml) since the
persistence.xml's all use unique pu names. Also, there was no test code to
drive the code where the warning is logged. Is one of the names used in
bad-persistence supposed to be a duplicate? Based on the code changes, the
warning does not get logged unless one tries to create an emf with pu name that
is a duplicate. I created a simple test program to force the condition and it
worked fine, but I think a test needs to be provided in order to produce and
validate the warning condition, if possible.
> Runtime enhancer doesn't work propery if there is a trailing persistence.xml
> file on the classpath.
> ---------------------------------------------------------------------------------------------------
>
> Key: OPENJPA-932
> URL: https://issues.apache.org/jira/browse/OPENJPA-932
> Project: OpenJPA
> Issue Type: Bug
> Components: kernel
> Affects Versions: 1.2.0, 2.0.0-M1, 2.0.0
> Reporter: Rick Curtis
> Attachments: OPENJPA-932.patch
>
>
> I have an application where I am using runtime class enhancement via the
> javaagent and I set openjpa.RuntimeUnenhancedClasses=unsupported. My
> application works fine when running on 1.1.0 but when I moved to 1.2.0 (and
> 2.0.0) I started getting errors because my classes aren't being enhanced.
> After debugging I determined that I had a jar on the end of my classpath that
> had a META-INF/persistence.xml file in it. The extra persistence.xml file has
> no PUs defined, and should have been ignored. When I removed that jar from my
> classpath things starting working again. It also works if I put my
> META-INF/persistence.xml file on the end of my classpath.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
