[ 
https://issues.apache.org/jira/browse/OPENJPA-962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708101#action_12708101
 ] 

Dianne Richards commented on OPENJPA-962:
-----------------------------------------

Thanks Catalina for your review.

>>1. use StringUtils.replace where applicable for more readable code 
This is a good suggestion except for one thing: It's possible to include quotes 
within a delimited string. I have actually done this successfully on Derby. If 
I do a generic replace, those quotes would be duplicated too, which is not what 
we want.

>> 2.in DBDictionary,
>>    delimitedCase seems to be the same as schemaCase, can we use the exsiting 
>> schemaCase ? 
Actually, although they use the same constants, they are not the same. 
schemaCase is used for undelimited strings while delimitedCase is used for 
delimited strings. For example, on DB2 and Derby, undelimited strings are 
stored as uppercase while, for delimited strings, the case is preserved.

> Support the use of delimited-identifiers
> ----------------------------------------
>
>                 Key: OPENJPA-962
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-962
>             Project: OpenJPA
>          Issue Type: Sub-task
>          Components: jpa
>    Affects Versions: 2.0.0
>            Reporter: Jeremy Bauer
>            Assignee: Dianne Richards
>         Attachments: manual_patch1.txt
>
>
> This task is to support the use of delimited-identifiers as defined by the 
> 2.0 specification.  The 10/31/2008 draft of the specification has some open 
> issues regarding this item and while the spec indicates delimited identifiers 
> can be enabled per an element in the persistence.xml,  the persistence schema 
> does contain the delimited-identifiers definition.   However, work could 
> begin on this item and the enablement of delimited identifiers could be 
> temporarily triggered via a config property (or some other means) to exercise 
> the capability.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to