[
https://issues.apache.org/jira/browse/OPENJPA-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711118#action_12711118
]
Donald Woods commented on OPENJPA-1062:
---------------------------------------
Thanks for taking the time to review, which was why I attached the patch
instead of just committing it. All the junit tests passed and I could have
read the dependencies wrong, but here is what I based the changes on -
By marking <scope>compile</scope>, then those dependencies are only used at
compile time and are not included as maven transitive dependencies, which helps
maven-bundle-plugin create more accurate bundle metadata. If you look at the
openjpa/pom.xml and openpa-all/pom.xml, the list of dependencies in there are
the true runtime dependencies (minus any Derby/JDBC drivers.)
openjpa-lib - Log4J is optional, as there are LogFactoryAdapter impls for
Log4J, Commons-logging and No logging.
openjpa-kernel - WebSphere jars are only for compile time of WAS container
integration support and are not included in the binary distribution.
openjpa-jdbc - Postgresql and Hsqldb are only compile time depends for the
PostgresqlDictionary and HSQLDictionary classes, which must be provided at
runtime by the user/app supplying the required JDBC driver. Ant is only needed
when calling the enhancer or reverse mapping tool from Ant.
I still want a couple more eyes to look at this (like maybe Mike) and I want to
run some more tests before committing.
> Include OSGi bundle metadata
> ----------------------------
>
> Key: OPENJPA-1062
> URL: https://issues.apache.org/jira/browse/OPENJPA-1062
> Project: OpenJPA
> Issue Type: Sub-task
> Components: build / infrastructure
> Affects Versions: 1.2.1, 1.3.0, 2.0.0
> Reporter: Donald Woods
> Assignee: Donald Woods
> Fix For: 2.0.0
>
> Attachments: OPENJPA-1062.patch
>
>
> Use the maven-bundle-plugin to generate the OSGi bundle metadata in the
> manifest.mf.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
