+1 to turn it off in both 1.3 and trunk.

Turning it off will not let it be forgotten. Every user who naively runs without benefit of enhancement will get a nice message just like today. The difference is that after getting the message that enhancement was not done, today the user continues and tomorrow the user will have to actually read the message.

The message should direct the user to explicit instructions on how to enhance the classes, and how to run without enhancement.

I can tell you that it took me a while to figure it out.

Craig

On May 20, 2009, at 3:45 PM, Pinaki Poddar wrote:


Hi Kevin,

 +1 on 1.3 if you mean "turn off" as
openjpa.RuntimeUnenhancedClasses=unsupported.

I am rather ambivalent about trunk though.

Few more aspects that we should take note of:
 1. We must recognize the core notion behind runtime enhancement is a
strong and useful feature.

 2. The available support has its flaws (which is the reason for this
discussion being resurrected) -- but more importantly, we do not know the footprint of the incompleteness of this feature. Given that we run our test corpus on enhanced classes only, we basically wait till a user's report is
diagnosed as yet another bug caused by this feature.

 3. "Turning it off" has the risk of this powerful feature being
"forgotten" -- if it turns out so, it will not be a desirable outcome.


-----
Pinaki Poddar                      http://ppoddar.blogspot.com/

http://www.linkedin.com/in/pinakipoddar
OpenJPA PMC Member/Committer
JPA Expert Group Member
--
View this message in context: 
http://n2.nabble.com/-VOTE--Turn-off-enhancement-by-subclassing-as-the-default-tp1616140p2949153.html
Sent from the OpenJPA Developers mailing list archive at Nabble.com.


Craig L Russell
Architect, Sun Java Enterprise System http://db.apache.org/jdo
408 276-5638 mailto:[email protected]
P.S. A good JDO? O, Gasp!

Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to