Hi Mike, > Are the files generated during the build process or are they committed to > SVN? They are committed to SVN. Other Junit Test code needs them at development/compile time.
> I think they should comply before we commit them. They are generated by an automatic source code writer. The writer/code generator does not have a notion of line length limit during output. To enforce it via that code generator is neither trivial for the way it emits different code elements nor I have bandwidth to invest. If compliance to line length limit is paramount, then whichever issue (I still could not find that JIRA) is handling that task may take that up. Michael Dick wrote: > > Are the files generated during the build process or are they committed to > SVN? > > If they're part of the build process then it's fair to exclude them, if > they're generated and then committed to SVN then I think they should > comply > before we commit them. > > -mike > > On Fri, Jun 5, 2009 at 8:36 AM, Pinaki Poddar <[email protected]> wrote: > >> >> Hi, >> > If there's any way to exclude these files >> 1. These files are created under openjpa-persistence-jdbc module's test >> packages >> 2. They are always named with a underscore at the end i.e. say >> Person_.java >> >> >> Craig L Russell wrote: >> > >> > >> > On Jun 4, 2009, at 9:38 AM, Pinaki Poddar wrote: >> > >> >> >> >> Hi, >> >> We are now checking in *.java files for canonical meta-model >> >> classes in >> >> SVN. Source code for these classes are auto-generated and may exceed >> >> 80-column per line. Noticed some work on enforcing 80-column limit >> >> on test >> >> source code -- can't locate the exact issue -- but anyway that work >> >> must >> >> consider exception for these auto-generated source files. >> > >> > +1 Let's not worry about generated files exceeding the 80 character >> > line limit. If there's any way to exclude these files from the checker >> > this should be an exception. >> > >> > Craig >> >> >> >> >> >> ----- >> >> Pinaki Poddar http://ppoddar.blogspot.com/ >> >> >> >> http://www.linkedin.com/in/pinakipoddar >> >> OpenJPA PMC Member/Committer >> >> JPA Expert Group Member >> >> -- >> >> View this message in context: >> >> >> http://n2.nabble.com/80-column-line-width---auto-generated-model-classes-tp3025746p3025746.html >> >> Sent from the OpenJPA Developers mailing list archive at Nabble.com. >> >> >> > >> > Craig L Russell >> > Architect, Sun Java Enterprise System http://db.apache.org/jdo >> > 408 276-5638 mailto:[email protected] >> > P.S. A good JDO? O, Gasp! >> > >> > >> > >> > >> >> >> ----- >> Pinaki Poddar http://ppoddar.blogspot.com/ >> >> http://www.linkedin.com/in/pinakipoddar >> OpenJPA PMC Member/Committer >> JPA Expert Group Member >> -- >> View this message in context: >> http://n2.nabble.com/80-column-line-width---auto-generated-model-classes-tp3025746p3030320.html >> Sent from the OpenJPA Developers mailing list archive at Nabble.com. >> >> > > ----- Pinaki Poddar http://ppoddar.blogspot.com/ http://www.linkedin.com/in/pinakipoddar OpenJPA PMC Member/Committer JPA Expert Group Member -- View this message in context: http://n2.nabble.com/80-column-line-width---auto-generated-model-classes-tp3025746p3030904.html Sent from the OpenJPA Developers mailing list archive at Nabble.com.
