Thank you for the good catch! I fixed it now.


----- Original Message ----
From: Craig L Russell <[email protected]>
To: [email protected]
Sent: Friday, June 26, 2009 10:16:39 AM
Subject: Re: svn commit: r788764 - 
/openjpa/branches/subquery/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/SubqueryImpl.java

Hi Fay,

This patch seems suspect. The cast doesn't match the expected return type. Or 
is PathImpl<?,?> assignment compatible with RootImpl<?>

I haven't studied this part of the specification...

Craig

On Jun 26, 2009, at 10:01 AM, [email protected] wrote:

> Author: faywang
> Date: Fri Jun 26 17:01:04 2009
> New Revision: 788764
> 
> URL: http://svn.apache.org/viewvc?rev=788764&view=rev
> Log:
> OPENJPA-1143: fix compiler error for IBM SDK5
> 
> Modified:
>    
> openjpa/branches/subquery/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/SubqueryImpl.java
> 
> Modified: 
> openjpa/branches/subquery/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/SubqueryImpl.java
> URL: 
> http://svn.apache.org/viewvc/openjpa/branches/subquery/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/SubqueryImpl.java?rev=788764&r1=788763&r2=788764&view=diff
> ==============================================================================
> --- 
> openjpa/branches/subquery/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/SubqueryImpl.java
>  (original)
> +++ 
> openjpa/branches/subquery/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/criteria/SubqueryImpl.java
>  Fri Jun 26 17:01:04 2009
> @@ -249,7 +249,7 @@
>     // should be the class metadata of the collection element
>     private ClassMetaData getCandidate() {
>         RootImpl<?> root = (RootImpl<?>)getRoot();
> -        RootImpl<?> correlatedRoot = (RootImpl<?>)root.getCorrelatedParent();
> +        PathImpl<?,?> correlatedRoot = 
> (RootImpl<?>)root.getCorrelatedParent();
>         if (correlatedRoot != null && root.getJoins() != null) {
>            Join<?,?> join = root.getJoins().iterator().next();
>            FieldMetaData fmd = ((Members.Member<?, 
> ?>)join.getAttribute()).fmd;
> 
> 

Craig L Russell
Architect, Sun Java Enterprise System http://db.apache.org/jdo
408 276-5638 mailto:[email protected]
P.S. A good JDO? O, Gasp!


      

Reply via email to