[ 
https://issues.apache.org/jira/browse/OPENJPA-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746900#action_12746900
 ] 

Michael Dick commented on OPENJPA-1260:
---------------------------------------

Hi Ravi,

The patch looks good but I'd recommend moving the testcase to a different 
package, org.apache.openjpa.persistence.jdbc.sequence or just 
org.apache.openjpa.persistence.sequence. The testcase isn't using delimited 
identifiers so it'd be a bit misleading to put it in that package. 

Otherwise the patch looks great. 

> Wrong sequence is generated for custom native sequence generator from 
> getIdGenerator.
> -------------------------------------------------------------------------------------
>
>                 Key: OPENJPA-1260
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1260
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: sql
>    Affects Versions: 2.0.0
>            Reporter: Ravi P Palacherla
>            Assignee: Ravi P Palacherla
>         Attachments: OPENJPA-1260-trunk.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to