[ 
https://issues.apache.org/jira/browse/OPENJPA-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999932#comment-12999932
 ] 

Milosz Tylenda commented on OPENJPA-1376:
-----------------------------------------

Palmer, thanks for the patch. I have modified it, e.g. allocate property is 
used instead of increment to be more consistent with table-based sequence, but 
the idea is the same. Committed.

I also got rid of the auto-configuration support which was marked deprecated 
from the beginning of OpenJPA (2006) which was interferring with this change.

Since this change poses some burden during migration, I will update the manual 
soon.


> @SequenceGenerator allocationSize incorrect implementation
> ----------------------------------------------------------
>
>                 Key: OPENJPA-1376
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1376
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: competitive, jdbc, performance
>    Affects Versions: 1.2.1, 2.0.0-M3
>         Environment: All
>            Reporter: Yves
>            Assignee: Milosz Tylenda
>             Fix For: 2.2.0
>
>         Attachments: cache-native-seq-values.diff
>
>   Original Estimate: 8h
>  Remaining Estimate: 8h
>
> OpenJpa use allocationSize parameter on NativeJDBCSeq to set the sequence 
> cache value.
> But one "JSR 220: Enterprise JavaBeansTM,Version 3.0" , the allocationSize is 
> : "The amount to increment by when allocating sequence
> numbers from the sequence."
> Allocating is used to limit the number of access to the sequence or table not 
> to set the sequence cache value !
> If allocationSize=50, the sequence need to be call one time on each 50 call 
> on AbstractJDBCSeq.next().
> 1 call on AbstractJDBCSeq.next(). call the sequence or table 
> 2 call : return previous value + 1;
> 3 call : return previous value + 2;
> ...
> 51 call :re-call the sequence
> 52 return previous value + 1
> ...

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to