[
https://issues.apache.org/jira/browse/OPENJPA-2554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14269732#comment-14269732
]
Kevin Sutter commented on OPENJPA-2554:
---------------------------------------
Hi Roberto,
I took a quick look and, in general, it looks like you are on the right
track... Of course, the proof is in the pudding -- that is, testing. I do
have a couple of quick observations...
o Messages need to be coded in localizer.properties files. This allows for
central control of all messages for possible translation by some of the vendors
who use OpenJPA in their products (ie. WebSphere). We do not require
debug/trace messages to be translatable, but all warnings, info, error, etc
need to be translatable.
o Besides the scanning and setting of the properties in persistence.xml, we
will also need tests to verify that these operations actually perform
(generating scripts, modifying database schemas, etc).
o Never use splat (*) when importing. Most of use Eclipse and have it
automagically do the import resolution statements. Additional (although far
from complete) coding guidelines can be found here:
http://openjpa.apache.org/coding-standards.html
Basically, I would suggest code-by-example and follow the code formatting that
is currently in place in the parts you are modifying.
o Another thing we're not perfect with, but strive for, is to have method
names begin with a "verb". Constructors, of course, wouldn't follow this rule,
but methods should try to follow this. Makes for easier code reading.
o I noticed where you added the openjpa.Log to a common persistence.xml file.
This was probably done just for your testing, but we don't want to accidentally
include that type of change in a submitted patch since we would be tracing SQL
for every junit test suite that we execute.
o Doc updates... Since these new javax.persistence properties mesh with
existing OpenJPA capabilities, we need to ensure that our docs are updated to
match. Explain where they are the same, where they are similar, and where they
differ. Here's a link on how to build the docs (since we don't do that by
default).
http://openjpa.apache.org/building.html#Building-Buildingjustthedocbookdocumentation
That's about it for now... Thanks for taking the initiative! Good luck.
Kevin
> JPA 2.1 - Schema Generation
> ---------------------------
>
> Key: OPENJPA-2554
> URL: https://issues.apache.org/jira/browse/OPENJPA-2554
> Project: OpenJPA
> Issue Type: New Feature
> Components: sql
> Affects Versions: 2.3.0
> Reporter: Roberto Cortez
> Priority: Blocker
> Labels: jpa21
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
