[ 
https://issues.apache.org/jira/browse/OPENJPA-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453481#comment-15453481
 ] 

Mark Struberg commented on OPENJPA-2663:
----------------------------------------

I think we can completely get rid of the class alltogether!

I tried to wrote a unit test and it turned out that it
* only works for classes which have a single non-default ct. You are out of 
luck if you have multiple ct or just a default ct.
* doesn't work for classes which have an abstract method ...

Next I looked where it was used: Those classes all had no abstract method but 
was just marked as abstract.
So I simply removed the abstract from those wrapper classes and use the 
oldschool 'new' operator instead now.

> cleanup ConcreteClassGenerator and move to ASM
> ----------------------------------------------
>
>                 Key: OPENJPA-2663
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2663
>             Project: OpenJPA
>          Issue Type: Sub-task
>          Components: kernel
>    Affects Versions: 3.0.0
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>             Fix For: 3
>
>
> ConcreteClassGenerator contains lots of unused methods and also uses serp



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to