Hi Maxim Not sure what missed but a ping here can help
For this patch i have 2 comments: - some minimum test - without mysql embed is ok - should be addee - probably add a flag for compatibility Le 23 mars 2018 07:25, "Maxim Solodovnik" <solomax...@gmail.com> a écrit : > Hello Romain, > > I actually tried to contribute to this project back in 2015 > https://issues.apache.org/jira/browse/OPENJPA-2567 > > my patch is still in JIRA .... unmerged > No comments ... > > What is the process? > Any special criteria for patches you are accepting? > > > On Fri, Mar 23, 2018 at 1:16 PM, Romain Manni-Bucau > <rmannibu...@gmail.com> wrote: > > Hi Jon and Maxim > > > > You can start by checking jira if you dont know what to do but Il sure > some > > features of jpa 2.1 are more exiting for you so maybe say you will work > on > > them, grab a ticket for it and ask here if you find any blocker. > > > > The weird thing for me was the kernel indirection we dont use in most > impl > > anymore bit once seen it works not bad. Also always test with maven, > > sometimes the pom are not well recognize by IDE until you bind some > plugins > > like enhancers but it is slow on big test suites to desire to skip it > quite > > often. > > > > > > Le 23 mars 2018 03:54, "Maxim Solodovnik" <solomax...@gmail.com> a > écrit : > > > > Unfortunately I can't contribute, but also interested in 2.1 > > Here is the issues I was able to find: > > https://issues.apache.org/jira/browse/OPENJPA-2556?jql= > labels%20%3D%20jpa21 > > > > On Fri, Mar 23, 2018 at 6:50 AM, Jonathan Gallimore > > <jonathan.gallim...@gmail.com> wrote: > >> Hi > >> > >> I don't know how much time I'll have, but I'd be interested in > > contributing > >> to OpenJPA, and I'm thinking around helping with JPA 2.1 support. > >> > >> I'm not too sure where to get started with respect to what needs doing - > >> are there JIRA tickets or a list of tasks that I can pick from? > >> > >> Any quick pointers would be appreciated. > >> > >> Cheers > >> > >> Jon > > > > > > > > -- > > WBR > > Maxim aka solomax > > > > -- > WBR > Maxim aka solomax >
