I would say OPENJPA-2754 can be closed as Resolved-Fixed   -- Any objections?

My opinion 3.0.1/3.1.0 in current state is step forward comparing to 3.0.0
I would say: let's release :)

On Mon, 25 Mar 2019 at 21:22, Francesco Chicchiriccò
<ilgro...@apache.org> wrote:
>
> Hi all,
> it seems we are quite stuck in this pre-release process, let's try to
> finalize the great work carried out lately.
>
> By looking at JIRA [1], OpenJPA 3.0.1 (or 3.1.0? it seems to me there
> was enough consensus around that), has 29 issues done and 15 to do, e.g.
> [2].
>
>  From there, I would say that:
>
> a. not complete, but can be postponed:
>
> OPENJPA-2662
> OPENJPA-2665 (should also be updated to Java 8)
> OPENJPA-2670
>
> b. to review because some work was probably done; resolve what done and
> postpone what to to:
>
> OPENJPA-2670
> OPENJPA-2753
> OPENJPA-2754
> OPENJPA-2709 and its children
>   * OPENJPA-2711
>   * OPENJPA-2712
>   * OPENJPA-2713
>   * OPENJPA-2714
>   * OPENJPA-2715
>
> c. issues reported but not yet confirmed or solved - to postpone:
>
> OPENJPA-2673
> OPENJPA-2694
> OPENJPA-2728
>
> Are you fine with such plan?
> All, but @Mark, @Maxim in particular: please review group (a) and (b),
> thanks.
>
> If we agree on that, I think we can start rolling over this long awaited
> release: WDYT?
>
> Regards.
>
> [1] https://issues.apache.org/jira/projects/OPENJPA/versions/12343421
> [2]
> https://issues.apache.org/jira/issues/?jql=statusCategory%20%3D%20new%20AND%20project%20%3D%2012310351%20AND%20fixVersion%20%3D%2012343421%20ORDER%20BY%20priority%20DESC%2C%20key%20ASC
>
> On 05/03/19 15:30, Romain Manni-Bucau wrote:
> > +1 for a release, 3.1.0 sounds good to me too
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <https://rmannibucau.metawerx.net/> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github 
> > <https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > <https://www.packtpub.com/application-development/java-ee-8-high-performance>
> >
> >
> > Le mar. 5 mars 2019 à 14:50, Francesco Chicchiriccò <ilgro...@apache.org> a
> > écrit :
> >
> >> Hi Mark,
> >> huge +1 for rolling a release - thanks for all your work.
> >>
> >> 3.1.0 would make sense, due to the API-level change - even though I
> >> don't think we'll ever release 3.0.1 with JPA 2.1, anyway...
> >>
> >> Regards.
> >>
> >> On 05/03/19 14:44, Mark Struberg wrote:
> >>> One more question:
> >>> What about the version?
> >>> [ ] 3.0.1 or[ ] 3.1.0 as we updated the spec-api version?
> >>> LieGrue,strub
> >>>       On Tuesday, 5 March 2019, 14:40:21 CET, Mark Struberg
> >> <strub...@yahoo.de.INVALID> wrote:
> >>>     We now have the official JPA-2.2 api jar. Our internal tests do pass.
> >>> There are surely a few more bugs to fix, but I'd say we can now do a
> >> release and focus on further bugfixes and more jpa-2.2 features later.
> >>> wdyt?
> >>> LieGrue,strub
> >>>
> >>>       On Wednesday, 20 February 2019, 08:01:46 CET, Francesco
> >> Chicchiriccò <ilgro...@apache.org> wrote:
> >>>    HI there,
> >>> what's the updated status here? Thanks!
> >>>
> >>> Regards.
> >>>
> >>> On 05/02/19 08:48, Mark Struberg wrote:
> >>>> And of course the open tickets from Pawel need to be reviewed/applied.
> >>>>
> >>>> LieGrue,
> >>>> strub
> >>>>
> >>>>> Am 05.02.2019 um 08:47 schrieb Mark Struberg <strub...@yahoo.de>:
> >>>>>
> >>>>> I worked around it with tweaking the commons-dbcp2 configuration.
> >>>>> More healthy defaults now ;)
> >>>>>
> >>>>> I'd love to finish the task for java8 time (MS SQLServer is missing
> >> and DB/2), then we can roll a release imo.
> >>>>> LieGrue,
> >>>>> strub
> >>>>>
> >>>>>
> >>>>>> Am 05.02.2019 um 08:30 schrieb Francesco Chicchiriccò <
> >> ilgro...@apache.org>:
> >>>>>> So...
> >>>>>>
> >>>>>> $ grep SNAPSHOT pom.xml
> >>>>>>       <version>3.0.1-SNAPSHOT</version>
> >>>>>>
> >>>>>> If I am not mistaking, there are no more SNAPSHOT dependencies: how
> >> about releasing 3.0.1?
> >>>>>> @Mark how about your ongoing work?
> >>>>>>
> >>>>>> Regards.
> >>>>>>
> >>>>>> On 05/02/19 05:08, Maxim Solodovnik wrote:
> >>>>>>> Thanks :)
> >>>>>>> have released artifact in Nexus and updated openjpa main pom
> >>>>>>>
> >>>>>>> so one snapshot down :)
> >>>>>>>
> >>>>>>> On Mon, 4 Feb 2019 at 23:50, Francesco Chicchiriccò <
> >> ilgro...@apache.org> wrote:
> >>>>>>>> Congrats Maxim!
> >>>>>>>>
> >>>>>>>>
> >> https://lists.apache.org/thread.html/9100867a1dd69651bcbc1567182c3763f46308f819f8d102154bdb09@%3Cdev.commons.apache.org%3E
> >>>>>>>> On 01/02/19 16:56, Maxim Solodovnik wrote:
> >>>>>>>>> Hello All,
> >>>>>>>>>
> >>>>>>>>> Finally commons-collections release might happen:
> >>>>>>>>> https://markmail.org/thread/n7o4ca4ffmpc4dlz :)
> >>>>>>>>>
> >>>>>>>>> On Wed, 19 Dec 2018 at 08:17, Maxim Solodovnik <
> >> solomax...@gmail.com> wrote:
> >>>>>>>>>> Hello All,
> >>>>>>>>>>
> >>>>>>>>>> I'm trying to create commons-collections RC1 hopefully will be
> >> released :)
> >>>>>>>>>> On Fri, 14 Dec 2018 at 03:04, Mark Struberg
> >> <strub...@yahoo.de.invalid>
> >>>>>>>>>> wrote:
> >>>>>>>>>>
> >>>>>>>>>>> I'd give it a test run.
> >>>>>>>>>>>
> >>>>>>>>>>> I upgraded to a snapshot version of commons-pool.
> >>>>>>>>>>> There is a workaround for the problems in this version though: to
> >>>>>>>>>>> increase maxIdle to something higher than 0;
> >>>>>>>>>>> That would be a sane default anyway.
> >>>>>>>>>>>
> >>>>>>>>>>> Will try to fix that over the weekend and go back to the releaed
> >>>>>>>>>>> commons-dbcp version.
> >>>>>>>>>>> Then I'm fine to go.
> >>>>>>>>>>>
> >>>>>>>>>>> LieGrue,
> >>>>>>>>>>> strub
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>> Am 04.12.2018 um 13:56 schrieb Francesco Chicchiriccò <
> >>>>>>>>>>> ilgro...@apache.org>:
> >>>>>>>>>>>> On 04/12/18 13:25, Maxim Solodovnik wrote:
> >>>>>>>>>>>>> Additionally some classes are being used without "import" (to
> >> have
> >>>>>>>>>>> same name)
> >>>>>>>>>>>> Yep:
> >>>>>>>>>>>>
> >>>>>>>>>>>> $ grep -r "commons\.collections" | grep "\.java" | sed
> >> 's/.*://' | sed
> >> 's/.*org.apache.commons.collections4/org.apache.commons.collections4/g' |
> >>>>>>>>>>> sort | uniq
> >>>>>>>>>>>> org.apache.commons.collections4.bidimap.TreeBidiMap;
> >>>>>>>>>>>>
> >> org.apache.commons.collections4.comparators.ComparableComparator;
> >>>>>>>>>>>> org.apache.commons.collections4.comparators.ComparatorChain;
> >>>>>>>>>>>> org.apache.commons.collections4.functors.,org.apache.xalan")),
> >>>>>>>>>>>> org.apache.commons.collections4.iterators.EmptyIterator;
> >>>>>>>>>>>> org.apache.commons.collections4.iterators.FilterIterator;
> >>>>>>>>>>>> org.apache.commons.collections4.iterators.IteratorChain;
> >>>>>>>>>>>> org.apache.commons.collections4.map.
> >>>>>>>>>>>>
> >> org.apache.commons.collections4.map.AbstractReferenceMap.ReferenceStrength;
> >>>>>>>>>>>> org.apache.commons.collections4.map.LinkedMap;
> >>>>>>>>>>>> org.apache.commons.collections4.map.LRUMap
> >>>>>>>>>>>> org.apache.commons.collections4.map.ReferenceMap
> >>>>>>>>>>>> org.apache.commons.collections4.map.ReferenceMap;
> >>>>>>>>>>>> org.apache.commons.collections4.Predicate;
> >>>>>>>>>>>> org.apache.commons.collections4.set.MapBackedSet;
> >>>>>>>>>>>>
> >>>>>>>>>>>>> On Tue, 4 Dec 2018 at 18:42, Francesco Chicchiriccò <
> >>>>>>>>>>> ilgro...@apache.org>
> >>>>>>>>>>>>> wrote:
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>> This is the list of classes from commons-collections4 we're
> >> depending
> >>>>>>>>>>> on
> >>>>>>>>>>>>>> ATM:
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> ~/work/openjpa$ grep -r commons.collections | grep import |
> >> sed
> >>>>>>>>>>>>>> 's/.*://'  | sort | uniq
> >>>>>>>>>>>>>> import org.apache.commons.collections4.bidimap.TreeBidiMap;
> >>>>>>>>>>>>>> import
> >>>>>>>>>>> org.apache.commons.collections4.comparators.ComparableComparator;
> >>>>>>>>>>>>>> import
> >> org.apache.commons.collections4.comparators.ComparatorChain;
> >>>>>>>>>>>>>> import
> >> org.apache.commons.collections4.iterators.EmptyIterator;
> >>>>>>>>>>>>>> import
> >> org.apache.commons.collections4.iterators.FilterIterator;
> >>>>>>>>>>>>>> import
> >> org.apache.commons.collections4.iterators.IteratorChain;
> >>>>>>>>>>>>>> import
> >>>>>>>>>>>>>>
> >> org.apache.commons.collections4.map.AbstractReferenceMap.ReferenceStrength;
> >>>>>>>>>>>>>> import org.apache.commons.collections4.map.LinkedMap;
> >>>>>>>>>>>>>> import org.apache.commons.collections4.map.ReferenceMap;
> >>>>>>>>>>>>>> import org.apache.commons.collections4.Predicate;
> >>>>>>>>>>>>>> import org.apache.commons.collections4.set.MapBackedSet;
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> Not many, actually...
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> On 04/12/18 10:55, Maxim Solodovnik wrote:
> >>>>>>>>>>>>>>> I'm afraid the one who will drop commons-collections should
> >> have
> >>>>>>>>>>> better
> >>>>>>>>>>>>>>> code-understanding than I'm :(
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> Here is the link to the discussion:
> >>>>>>>>>>>>>>>
> >> https://lists.apache.org/thread.html/a751aee1e7b667715db00f632579d39cd4241ab3ae6a39d6b35e577b@%3Cuser.commons.apache.org%3E
> >>>>>>>>>>>>>>> You can raise your voice :)
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> On Mon, 3 Dec 2018 at 22:10, Romain Manni-Bucau <
> >>>>>>>>>>> rmannibu...@gmail.com>
> >>>>>>>>>>>>>>> wrote:
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> Does the cost to drop it is that high? Really tempted to
> >> say it is a
> >>>>>>>>>>>>>> better
> >>>>>>>>>>>>>>>> solution for openjpa anyway on the mid term.
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> Le lun. 3 déc. 2018 à 16:08, Maxim Solodovnik <
> >> solomax...@gmail.com>
> >>>>>>>>>>> a
> >>>>>>>>>>>>>>>> écrit :
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>> I did ping commons-collwctions community (~6 days ago) -
> >> no answer
> >>>>>>>>>>>>>>>>> Will ping again
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>> On Mon, 3 Dec 2018 at 18:54, Francesco Chicchiriccò <
> >>>>>>>>>>>>>> ilgro...@apache.org
> >>>>>>>>>>>>>>>>> wrote:
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>> Hi,
> >>>>>>>>>>>>>>>>>> did we make any progress?
> >>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>> FYI: https://issues.apache.org/jira/browse/SYNCOPE-1400
> >>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>> Regards.
> >>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>> On 26/11/18 14:07, Maxim Solodovnik wrote:
> >>>>>>>>>>>>>>>>>>> Additionally commons-collections4 release is required
> >>>>>>>>>>>>>>>>>>> I'll ping commons community ....
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> On Mon, 26 Nov 2018 at 20:01, Francesco Chicchiriccò <
> >>>>>>>>>>>>>>>>>> ilgro...@apache.org>
> >>>>>>>>>>>>>>>>>>> wrote:
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>> Hi there,
> >>>>>>>>>>>>>>>>>>>> am I correct if I think that, once commons-pool2 and
> >>>>>>>>>>> commons-dbcp2
> >>>>>>>>>>>>>>>> are
> >>>>>>>>>>>>>>>>>>>> released, we will be able to release OpenJPA 3.0.1?
> >>>>>>>>>>>>>>>>>>>> We start needing its features and fixes at Syncope...
> >>>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>> Regards.
> >>>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>> On 2018/11/13 12:50:33, Mark Struberg wrote:
> >>>>>>>>>>>>>>>>>>>>> Go for it, I already removed tons of stuff for other
> >>>>>>>>>>> commons
> >>>>>>>>>>>>>>>> libs
> >>>>>>>>>>>>>>>>>>>> which we now do not need anymore.
> >>>>>>>>>>>>>>>>>>>>> We still need commons-dbcp (which requires
> >> commons-pool)
> >>>>>>>>>>> to be
> >>>>>>>>>>>>>>>>>>>> released before OpenJPA.
> >>>>>>>>>>>>>>>>>>>>> Will try to work on that today.
> >>>>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>>> LieGrue,
> >>>>>>>>>>>>>>>>>>>>> strub
> >>>>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>>>> Am 13.11.2018 um 08:35 schrieb Romain Manni-Bucau :
> >>>>>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>>>> There is some glue code need but nothing a stream cant
> >>>>>>>>>>> solve
> >>>>>>>>>>>>>>>> for
> >>>>>>>>>>>>>>>>>>>> most of
> >>>>>>>>>>>>>>>>>>>>>> it. The main work will be the map replacement but here
> >>>>>>>>>>> again,
> >>>>>>>>>>>>>>>>>>>> nothing crazy
> >>>>>>>>>>>>>>>>>>>>>> and worse case forking 2 classes is still worth it
> >> IMHO
> >>>>>>>>>>>>>>>>>>>>>> Le mar. 13 nov. 2018 07:54, Francesco Chicchiriccò a
> >>>>>>>>>>>>>>>>>>>>>> écrit :
> >>>>>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>>>>> On 13/11/18 07:18, Romain Manni-Bucau wrote:
> >>>>>>>>>>>>>>>>>>>>>>>> sounds good (but dropping a lib is too ;))
> >>>>>>>>>>>>>>>>>>>>>>> Agree: is there anything from commons-collections4
> >> that
> >>>>>>>>>>>>>>>> cannot
> >>>>>>>>>>>>>>>>> be
> >>>>>>>>>>>>>>>>>>>>>>> replaced by Java 8 features? Maybe some specialized
> >>>>>>>>>>>>>>>> collection,
> >>>>>>>>>>>>>>>>>> as
> >>>>>>>>>>>>>>>>>>>>>>> CollectionUtils, IterableUtils, etc can be easily
> >>>>>>>>>>> replaced.
> >>>>>>>>>>>>>>>>>>>>>>> Regards.
> >>>>>>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>>>>>> Le mar. 13 nov. 2018 à 07:10, Maxim Solodovnik a
> >>>>>>>>>>>>>>>>>>>>>>>> écrit :
> >>>>>>>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>>>>>>> According to this thread:
> >>>>>>>>>>>>>>>>>>>> https://markmail.org/message/dnbbribu6jvzozfo
> >>>>>>>>>>>>>>>>>>>>>>>>> commons-collections4
> >>>>>>>>>>>>>>>>>>>>>>>>> can
> >>>>>>>>>>>>>>>>>>>>>>>>> be released in a week or so ...
> >>>>>>>>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>>>>>>> On Tue, 13 Nov 2018 at 13:04, Romain Manni-Bucau >
> >>>>>>>>>>>>>>>>>>>>>>>>> wrote:
> >>>>>>>>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>>>>>>>> yep,
> >>>>>>>>>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>>>>>>>> side note: did a quick review and I guess we can
> >> drop
> >>>>>>>>>>>>>>>>>>>>>>> commons-collections
> >>>>>>>>>>>>>>>>>>>>>>>>>> with not much effort since we are on java8, pool2
> >> and
> >>>>>>>>>>>>>>>> dbcp2
> >>>>>>>>>>>>>>>>>> can
> >>>>>>>>>>>>>>>>>>>>>>> probably
> >>>>>>>>>>>>>>>>>>>>>>>>>> too writing a thin pool for tests (like a Queue
> >>>>>>>>>>> wrapper)
> >>>>>>>>>>>>>>>> but
> >>>>>>>>>>>>>>>>>> can
> >>>>>>>>>>>>>>>>>>>>>>> require
> >>>>>>>>>>>>>>>>>>>>>>>>>> more adaptation
> >>>>>>>>>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>>>>>>>> Le mar. 13 nov. 2018 à 06:43, Maxim Solodovnik
> >>>>>>>>>>>>>>>>>>>>>>> a
> >>>>>>>>>>>>>>>>>>>>>>>>>> écrit :
> >>>>>>>>>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>>>>>>>> Currently there are 3 SNAPSHOT dependencies
> >>>>>>>>>>>>>>>>>>>>>>>>>> I'm continuously pinging commons-collections
> >>>>>>>>>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>>>>>>>> Other 2 are commons-pool2 and commons-dbcp2
> >>>>>>>>>>> (introduced
> >>>>>>>>>>>>>> in
> >>>>>>>>>>>>>>>>>>>>>>>>>> https://github.com/apache/openjpa/pull/24,
> >>>>>>>>>>> currently not
> >>>>>>>>>>>>>>>>>> merged)
> >>>>>>>>>>>>>>>>>>>>>>>>>> I guess we should get these new releases first
> >>>>>>>>>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>>>>>>>> On Tue, 13 Nov 2018 at 12:39, Romain Manni-Bucau <
> >>>>>>>>>>>>>>>>>>>>>>> rmannibu...@gmail.com> wrote:
> >>>>>>>>>>>>>>>>>>>>>>>>>>>> Hi Maxim
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>>>>>>>>>> Tomee is waiting for a java11 release - mainly
> >> asm
> >>>>>>>>>>>>>>>>> upgrade.
> >>>>>>>>>>>>>>>>>>>>>>>>>>>> Once done +1
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>>>>>>>>>> Le mar. 13 nov. 2018 05:03, Maxim Solodovnik
> >>>>>>>>>>>>>>>>>>>>>>> a écrit :
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>> Hello All,
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>> 3.0.0 was release in June, lots of fixes were
> >>>>>>>>>>>>>> committed
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>> Maybe it's time for release?
> >>>>>>>>>>>>>> --
> >>>>>>>>>>>>>> Francesco Chicchiriccò
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> Tirasa - Open Source Excellence
> >>>>>>>>>>>>>> http://www.tirasa.net/
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> Member at The Apache Software Foundation
> >>>>>>>>>>>>>> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> >>>>>>>>>>>>>> http://home.apache.org/~ilgrosso/
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>
> >>>>>>>>>>>> --
> >>>>>>>>>>>> Francesco Chicchiriccò
> >>>>>>>>>>>>
> >>>>>>>>>>>> Tirasa - Open Source Excellence
> >>>>>>>>>>>> http://www.tirasa.net/
> >>>>>>>>>>>>
> >>>>>>>>>>>> Member at The Apache Software Foundation
> >>>>>>>>>>>> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> >>>>>>>>>>>> http://home.apache.org/~ilgrosso/
> >>>>>>>>>> --
> >>>>>>>>>> WBR
> >>>>>>>>>> Maxim aka solomax
>
> --
> Francesco Chicchiriccò
>
> Tirasa - Open Source Excellence
> http://www.tirasa.net/
>
> Member at The Apache Software Foundation
> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> http://home.apache.org/~ilgrosso/
>


-- 
WBR
Maxim aka solomax

Reply via email to