LGTM Le mar. 28 janv. 2020 à 09:04, Francesco Chicchiriccò <[email protected]> a écrit :
> I have added a test case, please have a look and let me know. > Regards. > > On 23/01/20 14:58, Romain Manni-Bucau wrote: > > I'd try to at least add a test (faking k8s with HttpServer is enough > IMHO) > > but it looks a good addition to me > > > > Romain Manni-Bucau > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > > <https://rmannibucau.metawerx.net/> | Old Blog > > <http://rmannibucau.wordpress.com> | Github < > https://github.com/rmannibucau> | > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > > < > https://www.packtpub.com/application-development/java-ee-8-high-performance > > > > > > > > Le jeu. 23 janv. 2020 à 14:50, Francesco Chicchiriccò < > [email protected]> > > a écrit : > > > >> Hi all, > >> it turned out that GCP Pub/Sub wasn't the most efficient mean to > >> implement, so we moved to a more generic Kubernetes approach. > >> > >> I have opened > >> > >> https://issues.apache.org/jira/browse/OPENJPA-2801 > >> > >> and > >> > >> https://github.com/apache/openjpa/pull/58 > >> > >> Please, have a look. > >> Regards. > >> > >> On 07/01/20 09:17, Mark Struberg wrote: > >>> +1 > >>> > >>> LieGrue, > >>> strub > >>> > >>>> Am 07.01.2020 um 08:40 schrieb Romain Manni-Bucau < > [email protected]>: > >>>> > >>>> Hi Francesco, > >>>> > >>>> Id say > >>>> > >>>> 1 yes > >>>> 2 new module > >>>> > >>>> Le mar. 7 janv. 2020 à 08:35, Francesco Chicchiriccò < > [email protected]> a écrit : > >>>> > >>>> Hi there, > >>>> there is chance I need to build a RemoteCommitProvider working with > Google Cloud Platform's Pub/Sub [1], their messaging service. > >>>> > >>>> From a high-level point of view, I believe I can mostly mimic [2], > even > >>>> though I would require to add [3] as dependency. > >>>> > >>>> Questions: > >>>> > >>>> 1. are we interested to embed such feature into OpenJPA? > >>>> 2. would it be fine do add [3] to openjpa-kernel or shall we build a > >>>> dedicated sub-module for such feature? > >>>> > >>>> Regards. > >>>> > >>>> [1] https://cloud.google.com/pubsub/docs/ > >>>> [2] > https://github.com/apache/openjpa/blob/master/openjpa-kernel/src/main/java/org/apache/openjpa/event/JMSRemoteCommitProvider.java > >>>> [3] https://github.com/googleapis/java-pubsub > > -- > Francesco Chicchiriccò > > Tirasa - Open Source Excellence > http://www.tirasa.net/ > > Member at The Apache Software Foundation > Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail > http://home.apache.org/~ilgrosso/ > >
