jgrassel commented on pull request #64: URL: https://github.com/apache/openjpa/pull/64#issuecomment-657792504
Personally, I'm not a fan of the "exclude list", because that adds a lot of unnecessary processing time, as String comparing a jar with hundreds and even thousands of classes against a group of patterns is not going to come cheap. In an application server environment, as long as the jpa provider impl is not bundled with the application (that is, loaded by the same classloader that we register a class transformer with), then the reentrancy that the `_transforming` boolean was put in to guard against is not going to happen. But it can if openjpa is bundled as part of the application and is loaded by the classloader which has the transformer registered to it. That's what Marc's original method was to guard against. But like I've said many times now, with ClassLoaders that permit concurrent classloading (and thus concurrent enhancing), the boolean method falls short because it doesn't detect thread-scoped reentrancy. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
