rmannibucau commented on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658353355


   @jgrassel yes it violates but it is important to have it when startup time 
is needed otherwise you basically potentially load all your app twice for 
nothing (or load it all in mem which is not better). It is a common 
"workaround" for a poorly written spec if you want but it is used. Also note 
that strictly speaking it is compliant with the spec if you use a javaagent 
(even if I can agree it was maybe not the original intent but technically it is 
and it fully match the original goal of ensuring runtime enhancement works :).
   
   About the loading: we just don't know as explained in previous message so we 
can't just have a skip flag (per thread or not). My PR works well while you use 
openjpa provided classes, with extensions it can requires some more work in 
integration code (wrap the transformer basically to prefilter known extensions) 
or we should add a config for the exclusion list in the pu (think it would be 
good anyway).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to