[ 
https://issues.apache.org/jira/browse/OPENJPA-2842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241325#comment-17241325
 ] 

Romain Manni-Bucau commented on OPENJPA-2842:
---------------------------------------------

[~struberg] let's make it simple, OPENJPA-2752 just intent to upgrade libs and 
moving from log4j1 to log4j2 is not a lib upgrade so it is a bug and we revert 
it. We add a log4j2 impl (+ option) and we're done. We just document it clearly 
in 3.1.3 annoucement and flag it as a bug. TomEE does not set openajp.Log to 
log4j - if so it is a bug, it must respect user config or use tomee logging - 
which is not log4j by default. The "use 2 if there and 1 is not" is as broken 
as the opposite since it is finally random as mentionned. People not having 
upgraded from < 3.1.0 - and some will upgrade from there - will be broken, so 
let's not do that step which will require a revert anyway after and just do it 
as it should have been straight. If we really want a "guess" algo we must use 
an "auto" flag IMHO.

> openjpa.Log=log4j should automatically switch between log4j-1.x and 2.x
> -----------------------------------------------------------------------
>
>                 Key: OPENJPA-2842
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2842
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: logging
>    Affects Versions: 3.1.2
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>            Priority: Major
>             Fix For: 3.1.3
>
>
> Somewhen in 2018 we added support for log4j2. Sadly we killed log4j-1.x 
> support (which is still widely in use).
>  
> We should automatically detect which version of log4j is available and then 
> use that.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to