rmannibucau commented on a change in pull request #79:
URL: https://github.com/apache/openjpa/pull/79#discussion_r611069648
##########
File path: pom.xml
##########
@@ -1102,6 +1102,58 @@
</properties>
</profile>
+ <!-- Profile for testing with HerdDB -->
+ <profile>
+ <id>test-herddb-docker</id>
+ <activation>
+ <property>
+ <name>test-herddb-docker</name>
+ </property>
+ </activation>
+ <dependencies>
+ <dependency>
+ <groupId>org.herddb</groupId>
+ <artifactId>herddb-jdbc</artifactId>
+ <version>0.22.0</version>
+ <scope>test</scope>
+ </dependency>
+ </dependencies>
+ <properties>
+
<connection.driver.name>herddb.jdbc.Driver</connection.driver.name>
Review comment:
I would dependency:unpack the zip/stack and just launch it with a
dedicated classloader (no conflict wth openjpa)
Docker is fine but don't expect it to be ran often except on the CI from
time to time - this is my main point, only Mark runs docker profiles AFAIK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
