rmannibucau commented on a change in pull request #93:
URL: https://github.com/apache/openjpa/pull/93#discussion_r811209144
##########
File path: openjpa/pom.xml
##########
@@ -129,48 +129,19 @@
</artifactSet>
<relocations>
<relocation>
-
<pattern>javax.annotation.security</pattern>
-
<shadedPattern>jakarta.annotation.security</shadedPattern>
+ <pattern>javax.annotation</pattern>
+
<shadedPattern>jakarta.annotation</shadedPattern>
+ <excludes>
+
<exclude>javax.annotation.process.**</exclude>
+ </excludes>
</relocation>
<relocation>
-
<pattern>javax.annotation.Generated</pattern>
-
<shadedPattern>jakarta.annotation.Generated</shadedPattern>
- </relocation>
- <relocation>
-
<pattern>javax.annotation.PostConstruct</pattern>
-
<shadedPattern>jakarta.annotation.PostConstruct</shadedPattern>
- </relocation>
- <relocation>
-
<pattern>javax.annotation.PreDestroy</pattern>
-
<shadedPattern>jakarta.annotation.PreDestroy</shadedPattern>
- </relocation>
- <relocation>
-
<pattern>javax.annotation.Resource</pattern>
-
<shadedPattern>jakarta.annotation.Resource</shadedPattern>
- </relocation>
- <relocation>
-
<pattern>javax.annotation.Resources</pattern>
-
<shadedPattern>jakarta.annotation.Resources</shadedPattern>
- </relocation>
- <relocation>
- <pattern>javax.el</pattern>
Review comment:
not used ;)
but guess it is worth a test ran after shade goal execution to validate the
produced jar does not contain any javax.xxx which is unexpected (using asm
since we have it in the cp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
