On Tue, 6 Feb 2024 at 14:03, Francesco Chicchiriccò <ilgro...@apache.org> wrote:
>
> On 06/02/24 04:07, Maxim Solodovnik wrote:
> > Hello Francesco,
> >
> > On Mon, 5 Feb 2024 at 19:16, Francesco Chicchiriccò <ilgro...@apache.org> 
> > wrote:
> >> Hi Maxim, if I follow [1] for Linux, I am doing
> >>
> >> sha1sum apache-openjpa-4.0.0-source.zip
> >>
> >> and then compare the value obtained with the content of
> > Hashes definitely passes "comparing by eye"
> > but :)) `sha1sum --check` able to check properly formatted hashes
> > automatically :)
> > AFAIK this is known behavior of hashes generated by java/maven
> >
> >> sha1sum apache-openjpa-4.0.0-source.zip
> >>
> >> I confirm that those are matching.
> >>
> >> Side note: MD5 and SHA-1 are deprecated, we should move to SHA-256 or 
> >> SHA-512 anytime soon.
> > I would agree :)
> >
> >> About build errors, I confirm that local build works fine for me, and so 
> >> did last commit available on GitHub [2].
> >>
> >> I cannot see in git, however, the tag from which the 4.0.0 artifacts were 
> >> built, nor the commits for version advance: Mark, can you push your local 
> >> commits and tag?
> > I have downloaded "source" artifact from here:
> > https://repository.apache.org/content/repositories/orgapacheopenjpa-1012/org/apache/openjpa/apache-openjpa/4.0.0/
> >
> > check, unzip and build it :)
>
> Yup, just did the same and it worked flawlessly.
>
> FYI built with
>
> Apache Maven 3.9.5 (57804ffe001d7215b5e7bcb531cf83df38f93546)
> Maven home: /opt/apache-maven-3.9.5
> Java version: 11.0.21, vendor: Azul Systems, Inc., runtime: 
> /usr/lib/jvm/zulu11-ca-amd64
> Default locale: it_IT, platform encoding: UTF-8
> OS name: "linux", version: "6.5.0-15-generic", arch: "amd64", family: "unix"

My bad
I was using Java17 :((

Everything works as expected with Java 11!
Sorry for the noise

I'm changing my VOTE to be +1 :))

>
> Regards.
>
> > [1] https://www.apache.org/info/verification.html#CheckingHashes
> > [2] 
> > https://github.com/apache/openjpa/commit/65eab774b3d41f978174a8777018e0f1c105d996
> >
> > On 05/02/24 05:44, Maxim Solodovnik wrote:
> >>> Hello All,
> >>>
> >>> My VOTE is +0.5
> >>>
> >>> Apache OpenMeeting works as expected with pre-build version
> >>>
> >>>
> >>> Here are the problems I got:
> >>>
> >>> Signatures check (with standard Linux utilities) failed:
> >>>       md5sum --check apache-openjpa-4.0.0-source.zip.md5
> >>> md5sum: apache-openjpa-4.0.0-source.zip.md5: no properly formatted MD5
> >>> checksum lines found
> >>>
> >>>       sha1sum --check apache-openjpa-4.0.0-source.zip.sha1
> >>> sha1sum: apache-openjpa-4.0.0-source.zip.sha1: no properly formatted
> >>> SHA1 checksum lines found
> >>>
> >>>
> >>> build from sources failed:
> >>>
> >>> [INFO] -------------------------------------------------------
> >>> [INFO]  T E S T S
> >>> [INFO] -------------------------------------------------------
> >>> [INFO] Running 
> >>> org.apache.openjpa.event.kubernetes.KubernetesTCPRemoteCommitProviderTest
> >>> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time
> >>> elapsed: 1.122 s <<< FAILURE! - in
> >>> org.apache.openjpa.event.kubernetes.KubernetesTCPRemoteCommitProviderTest
> >>> [ERROR] 
> >>> org.apache.openjpa.event.kubernetes.KubernetesTCPRemoteCommitProviderTest.addresses
> >>>    Time elapsed: 1.095 s  <<< FAILURE!
> >>> java.lang.AssertionError: expected:<2> but was:<0>
> >>> at org.junit.Assert.fail(Assert.java:89)
> >>> at org.junit.Assert.failNotEquals(Assert.java:835)
> >>> at org.junit.Assert.assertEquals(Assert.java:647)
> >>> at org.junit.Assert.assertEquals(Assert.java:633)
> >>> at 
> >>> org.apache.openjpa.event.kubernetes.KubernetesTCPRemoteCommitProviderTest.addresses(KubernetesTCPRemoteCommitProviderTest.java:165)
> >>> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> >>> Method)
> >>> at 
> >>> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> >>> at 
> >>> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> >>> at java.base/java.lang.reflect.Method.invoke(Method.java:568)
> >>> at 
> >>> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> >>> at 
> >>> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> >>> at 
> >>> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> >>> at 
> >>> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> >>> at 
> >>> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> >>> at 
> >>> org.jmock.integration.junit4.JUnitRuleMockery$1.evaluate(JUnitRuleMockery.java:48)
> >>> at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
> >>> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> >>> at 
> >>> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> >>> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> >>> at 
> >>> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> >>> at 
> >>> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> >>> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> >>> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> >>> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> >>> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> >>> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> >>> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> >>> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> >>> at 
> >>> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:377)
> >>> at 
> >>> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:284)
> >>> at 
> >>> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:248)
> >>> at 
> >>> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:167)
> >>> at 
> >>> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:456)
> >>> at 
> >>> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:169)
> >>> at 
> >>> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:595)
> >>> at 
> >>> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:581)
> >>>
> >>> [INFO]
> >>> [INFO] Results:
> >>> [INFO]
> >>> [ERROR] Failures:
> >>> [ERROR]   KubernetesTCPRemoteCommitProviderTest.addresses:165
> >>> expected:<2> but was:<0>
> >>> [INFO]
> >>> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0
> >>> [INFO]
> >>> [INFO] 
> >>> ------------------------------------------------------------------------
> >>> [INFO] Reactor Summary for OpenJPA Parent POM 4.0.0:
> >>> [INFO]
> >>> [INFO] OpenJPA Parent POM ................................. SUCCESS [  
> >>> 2.014 s]
> >>> [INFO] OpenJPA Utilities Library .......................... SUCCESS [  
> >>> 5.607 s]
> >>> [INFO] OpenJPA Kernel ..................................... SUCCESS [  
> >>> 4.281 s]
> >>> [INFO] OpenJPA JDBC ....................................... SUCCESS [  
> >>> 3.378 s]
> >>> [INFO] OpenJPA Persistence ................................ SUCCESS [  
> >>> 1.994 s]
> >>> [INFO] OpenJPA Persistence JDBC ........................... SUCCESS 
> >>> [10:02 min]
> >>> [INFO] OpenJPA Persistence Locking Tests .................. SUCCESS 
> >>> [23:31 min]
> >>> [INFO] OpenJPA tools ...................................... SUCCESS [  
> >>> 0.028 s]
> >>> [INFO] OpenJPA Maven Plugin ............................... SUCCESS [ 
> >>> 34.834 s]
> >>> [INFO] OpenJPA XML Store .................................. SUCCESS [  
> >>> 1.679 s]
> >>> [INFO] OpenJPA Slice ...................................... SUCCESS [  
> >>> 0.614 s]
> >>> [INFO] OpenJPA JEST ....................................... SUCCESS [  
> >>> 3.228 s]
> >>> [INFO] OpenJPA Kubernetes ................................. FAILURE [  
> >>> 2.101 s]
> >>> [INFO] OpenJPA Aggregate Jar .............................. SKIPPED
> >>> [INFO] OpenJPA Aggregate Jar with Dependencies ............ SKIPPED
> >>> [INFO] OpenJPA Project Docs and Assemblies ................ SKIPPED
> >>> [INFO] OpenJPA Examples ................................... SKIPPED
> >>> [INFO] OpenJPA Examples - Simple .......................... SKIPPED
> >>> [INFO] OpenJPA Examples - image-gallery ................... SKIPPED
> >>> [INFO] OpenJPA Examples - OpenBooks ....................... SKIPPED
> >>> [INFO] OpenJPA Integration Tests .......................... SKIPPED
> >>> [INFO] OpenJPA Integration Tests - Daytrader .............. SKIPPED
> >>> [INFO] OpenJPA Integration Tests - Examples ............... SKIPPED
> >>> [INFO] OpenJPA Integration Tests - SLF4JLogFactory ........ SKIPPED
> >>> [INFO] OpenJPA Integration Tests - JPA TCK ................ SKIPPED
> >>> [INFO] OpenJPA Integration Tests - Bean Validation ........ SKIPPED
> >>> [INFO] OpenJPA Integration Tests - JMX Platform MBeans .... SKIPPED
> >>> [INFO] OpenJPA Fetching Statistic Tool .................... SKIPPED
> >>> [INFO] OpenJPA Fetching Statistic Tool -- WAS Bundle ...... SKIPPED
> >>> [INFO] OpenJPA Features ................................... SKIPPED
> >>> [INFO] OpenJPA JUnit 5 .................................... SKIPPED
> >>> [INFO] 
> >>> ------------------------------------------------------------------------
> >>> [INFO] BUILD FAILURE
> >>> [INFO] 
> >>> ------------------------------------------------------------------------
> >>> [INFO] Total time:  34:33 min
> >>>
> >>> On Sat, 3 Feb 2024 at 14:23, Romain Manni-Bucau <rmannibu...@gmail.com> 
> >>> wrote:
> >>>> +1
> >>>>
> >>>> Le sam. 3 févr. 2024 à 07:06, Francesco Chicchiriccò 
> >>>> <ilgro...@apache.org>
> >>>> a écrit :
> >>>>
> >>>>> On 02/02/24 17:58, Mark Struberg wrote:
> >>>>>> Good afternoon!
> >>>>>>
> >>>>>> I'd like to call a VOTE on releasing Apache OpenJPA-4.0.0
> >>>>>> This is a release targetting the JPA-3.0 spec. Note that we do not yet
> >>>>> pass all the TCK tests, so we will not claim full compat albeit we are
> >>>>> working on it.
> >>>>>> The staging repo is
> >>>>>>
> >>>>> https://repository.apache.org/content/repositories/orgapacheopenjpa-1012/
> >>>>>> The source distribution can be found at
> >>>>>>
> >>>>> https://repository.apache.org/content/repositories/orgapacheopenjpa-1012/org/apache/openjpa/apache-openjpa/4.0.0/
> >>>>>> sha1 is 3ca5e4e0c8c7721a208f4889ac7728d8ad4861b5
> >>>>>>
> >>>>>> Please VOTE:
> >>>>>>
> >>>>>> [+1] ship it!
> >>>>>> [+0] don't care
> >>>>>> [-1] there is a ${showstopper}
> >>>>>>
> >>>>>> The VOTE is open for 72h.
> >>>>> +1 Regards.
>
> --
> Francesco Chicchiriccò
>
> Tirasa - Open Source Excellence
> http://www.tirasa.net/
>
> Member at The Apache Software Foundation
> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> http://home.apache.org/~ilgrosso/
>


-- 
Best regards,
Maxim

Reply via email to