cristof commented on code in PR #144:
URL: https://github.com/apache/openjpa/pull/144#discussion_r3414784383
##########
openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/jdbc/meta/TestJDBCSchemaManager.java:
##########
@@ -107,6 +109,11 @@ public void testTruncate() {
@Test
public void testValidate() {
EntityManagerFactory emf = createEMF(UUIDEntity.class,
EntityBoolChar.class, DROP_TABLES);
+ DBDictionary dict = getDbDictionary(emf);
+ if (dict instanceof MySQLDictionary) {
Review Comment:
Hi, @solomax! I get a failed test on mysql:lts (docker, version
8.4.8-1.el9). Inspecting it, I found that the tinybit used for bool makes the
testValidate fail because MysqlDbDictionary treats it as a number and then the
actual test (should throw SchemaValidationException) fails.
Tested it again here without my exception and it fails.
I'm using maven:3-eclipse-temunin-17 (docker) to test the codebase, and
mysql:sql (docker) as db target. Testing on pg (18, 17), h2 (2), hsql and
mariadb (lts and latest) are all green here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
