solomax commented on code in PR #144: URL: https://github.com/apache/openjpa/pull/144#discussion_r3584804182
########## openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/jpql/functions/TestEJBQLFunction.java: ########## Review Comment: Another issue is: ``` [ERROR] TestJPQLScalarExpressions>AbstractPersistenceTestCase.run:213->AbstractPersistenceTestCase.runBare:553->AbstractPersistenceTestCase.runBare:577->AbstractPersistenceTestCase.runTest:590->testSimpleCaseExpressions:212 the result is not male expected:<Male> but was:<Male > ``` on this JPQL: https://github.com/apache/openjpa/blob/OPENJPA-2940/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/jpql/expressions/TestJPQLScalarExpressions.java#L201 I believe this is because `Male` is right-padded with spaces to match the length of `Female` I'm going to add comparison using `trim/equalsIgnoreCase` Would it be OK? :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
