rzo1 commented on PR #144:
URL: https://github.com/apache/openjpa/pull/144#issuecomment-4999604481
@solomax I looked into the
`Client2#createEntityManagerFactoryNoBeanValidatorTest` issue and could
reproduce both states on PostgreSQL 16. The test actually **passes** without
the bval change: it verifies JPA spec 3.6.1 — `ValidationMode.CALLBACK` with
*no* Bean Validation provider on the classpath must end in a
`PersistenceException`, and OpenJPA already throws it
(`ValidationUnavailableException` → wrapped in `PersistenceProviderImpl`). The
`ERROR ... A default ValidatorFactory could not be created` stack trace in the
log is expected output on the passing path.
That's also why the TCK runs this single test in the separate
`persistence-tests-2` execution: `persistence-tests-1` gets hibernate-validator
via `${validator.classes}`, while `persistence-tests-2` deliberately has no
validator. Adding `org.apache.bval.bundle` to our profile puts a validator on
both classpaths, so the EMF now gets created, `em.persist()` runs, and it fails
on the unenhanced `Order`/`Member` classes instead — could you revert 45880938d?
Re `jpa.provider.implementation.specific.properties` "not working": for this
one test that's by TCK design — `Client2` passes the raw `myProps` to
`createEntityManagerFactory` and never calls
`PMClientBase.getPersistenceUnitProperties()`, which is the only place that
string gets parsed into `openjpa.*` properties. For all other tests it works
fine.
Verified A/B/A on `postgres:16` with a fresh branch-tip build, running only
the `persistence-tests-2` execution: without bval → `Tests run: 1, Failures: 0,
Errors: 0`; with bval → the `ArgumentException: This configuration disallows
runtime optimization` failure you saw; reverted → green again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
