solomax commented on code in PR #144:
URL: https://github.com/apache/openjpa/pull/144#discussion_r3802190608
##########
openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/test/SQLListenerTestCase.java:
##########
@@ -57,9 +58,17 @@ public void tearDown() throws Exception {
* @param sqlExp the SQL expression. E.g., "SELECT FOO .*"
*/
public void assertSQL(String sqlExp) {
+ DBDictionary dict = getDBDictionary();
for (String statement : sql) {
- if (statement.matches(sqlExp))
+ if (statement.matches(sqlExp)) {
+ return;
+ }
+ String noDelims = statement
Review Comment:
Different DBs have slightly different reserved keywords list. Plus for
whatever reason keyword escaping is something treated as unnecessary
I do remember I saw test creating DB table with name `TABLE` and checking it
wasn't escaped ...
there are lots of tests checking SQL matches exactly and they were failing
I can add method comment like above
Would it be sufficient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
