[
https://issues.apache.org/jira/browse/OPENJPA-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18109418#comment-18109418
]
ASF subversion and git services commented on OPENJPA-2987:
----------------------------------------------------------
Commit c5718f503c9e5ce856e942e718a639f6d6ff86f2 in openjpa's branch
refs/heads/master from Paulo Cristovão de Araújo Silva Filho
[ https://gitbox.apache.org/repos/asf?p=openjpa.git;h=c5718f503 ]
Merge pull request #152 from apache/OPENJPA-2987
[OPENJPA-2987] Restore externalized-parameter assertions
> Externalized-parameter tests reduced to no-op assertions
> --------------------------------------------------------
>
> Key: OPENJPA-2987
> URL: https://issues.apache.org/jira/browse/OPENJPA-2987
> Project: OpenJPA
> Issue Type: Sub-task
> Components: jpa
> Affects Versions: 4.2.0
> Reporter: Maxim Solodovnik
> Priority: Major
> Fix For: 4.2.0
>
>
> Discussion thread:
> https://github.com/apache/openjpa/pull/144#discussion_r3683006222
> **(high)** These three tests kept their names ("CanDetectExternalized...")
> but no longer detect anything: the `getExpressions()` helper was deleted and
> the `isUsingExternalizedParameter(...)` assertions were replaced by
> `assertNotNull(getResultList())`, which can never fail. Was
> externalized-parameter detection actually removed from the prepared-query
> cache, or can the original assertions be restored? As written the tests are
> no-ops.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
