rzo1 opened a new pull request, #175: URL: https://github.com/apache/openjpa/pull/175
To answer the review question: no single TCK test demands this, but the TCK's own persistence units list plain classes such as `LineItemException` alongside entities, so a provider that throws cannot create those EMFs. Jakarta Persistence 3.2 chapter 8 says nothing about a listed class that is not a managed type, so the behaviour is provider-defined, and Hibernate and EclipseLink both skip. The skip therefore stays. What was wrong is that it was silent, so a forgotten `@Entity` annotation or a missing `orm.xml` entry went unreported. Building the metamodel skipped without a word; schema synchronization warned with a hardcoded English string. Both now log a message naming the class and what to check, and the reasoning sits next to the code rather than only in the commit log. The migration considerations are corrected too: they claimed a warning on a log that does not carry one, and did not mention that with the default `openjpa.RuntimeUnenhancedClasses=unsupported` such a class is still rejected at start-up by the runtime enhancer. Note that the runtime-enhancer skip site is unreachable under that default, so no warning was added there; making that path report missing metadata rather than "runtime optimization disabled" would be a separate change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
