rzo1 opened a new pull request, #254: URL: https://github.com/apache/openjpa/pull/254
https://issues.apache.org/jira/browse/OPENJPA-3046 A criteria parameter used only in the ON condition of a join was not registered, so `setParameter` failed with "Parameter named n is not declared". `collectParameters` never visited the roots, and a join did not visit its ON predicate. - `FromImpl.acceptVisit` visits the ON predicate of a join (and stops on nodes already visited, so an ON condition referring back to its own join does not loop). - `CriteriaQueryImpl.collectParameters` visits all roots and, in a subquery, the correlated joins. Same approach as OPENJPA-3040. New `TestJoinOnParameters` (9 tests: set joins, nested joins, positional parameters, subquery and correlated joins). Full suites pass on Derby and H2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
