rzo1 commented on code in PR #266:
URL: https://github.com/apache/openjpa/pull/266#discussion_r4472098036
##########
openjpa-persistence/src/main/java/org/apache/openjpa/persistence/XMLPersistenceMetaDataParser.java:
##########
@@ -2402,6 +2405,18 @@ protected boolean isDeferredEmbeddable(Class<?>
embedType,
return false;
}
+ /**
+ * Share the deferred embeddable metadata of the given parser, which is
+ * the parser of the enclosing parse in a multi-level parse. The nested
+ * parser then sees and processes the deferrals of the enclosing parse.
+ */
+ public void shareDeferredEmbeddables(XMLPersistenceMetaDataParser parser) {
+ if (parser == null || parser == this)
Review Comment:
Done in 84abab4.
##########
openjpa-tools/openjpa-maven-plugin/src/it/sqlActionRefresh/src/main/sql/database.sql:
##########
@@ -1,2 +1,17 @@
+-- Licensed to the Apache Software Foundation (ASF) under one or more
Review Comment:
Done, it now has the same one-line header as the other test SQL files. RAT
0.16.1 accepts it.
##########
pom.xml:
##########
@@ -47,6 +47,8 @@
<openjpa.Log>DefaultLevel=INFO</openjpa.Log>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<checkstyle.suppressions.location>openjpa-project${file.separator}suppressions.xml</checkstyle.suppressions.location>
+ <!-- apache-rat-plugin 0.17/0.18 are not thread safe (CME and ignored
excludes in parallel builds, mvn -T) -->
Review Comment:
There is already one: RAT-573 fixes the thread safety, but only in 1.0.0,
which is not released yet. I added the reference to the pom comment (052fec2)
so we can drop the pin once 1.0.0 is out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
