rzo1 opened a new pull request, #263:
URL: https://github.com/apache/openjpa/pull/263

   https://issues.apache.org/jira/browse/OPENJPA-3062
   
   Fixes the failing MySQL and MariaDB jobs of the Databases workflow (run 
41567325486).
   
   **Decimals rounded to integers** (`TestDecimalScale`, `TestUnarySign`, 
`TestArithmeticResultType`): MySQL and MariaDB create an unsized 
`NUMERIC`/`DECIMAL` as `DECIMAL(10,0)`. Same problem as OPENJPA-3051 on H2.
   - `DECIMAL` is no longer a fixed size type, so sized columns keep `(p, s)` 
(`NUMERIC` already was).
   - A decimal column of a non-integral type without a precision is created as 
`NUMERIC(65, scale)`: the mapped scale, or 30 if none is given, at most 30.
   - `BigInteger`, a `columnDefinition` and a configured 
`NumericTypeName`/`DecimalTypeName` are kept.
   - `isUnsizedDecimal` moved from `H2Dictionary` to `DBDictionary` so both use 
it.
   - Migration note added; existing `DECIMAL(10,0)` columns are not altered.
   
   **`TestInMemoryJDBCEscapeLiterals.testCaseAndNullIfInMemory`**: the 
in-memory result is right. MySQL 8.4 returns `NULLIF` over a `DATETIME` as a 
string, 9.7 as a `LocalDateTime`, so the test now compares the database values 
as timestamps.
   
   Full suite passes on MySQL 8.4, MariaDB 12.3, Derby and H2.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to