rzo1 commented on PR #283:
URL: https://github.com/apache/openjpa/pull/283#issuecomment-6717782304
@solomax Good point, I'd go for it. Services are mainly there because they
were the quickest way to get a database up. With `docker:start`/`docker:stop`:
- The pom is the only place for image, env and ports, and CI runs exactly
what we run locally.
- Things a service can't do work: the Oracle init script mount, and the
MySQL `--lower_case_table_names` arg from the profile, which the CI service
silently drops today.
- The matrix version can be passed in, e.g. `-Dmysql.server.version=${{
matrix.version }}`.
One thing is missing first: only the Oracle profile has a `<wait>`. For
MySQL, MariaDB, PostgreSQL and SQL Server, `docker:start` returns before the
database accepts connections. A service waits for its health check, which is
why it works there. Each profile needs a `<wait>` on the "ready" log line, as
the Oracle one has. That's also better locally.
I'd keep #283 to what it does now and use `docker:start` only for Oracle
there, since it needs the init script. Moving the other databases over can be a
small follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
