rzo1 opened a new pull request, #290: URL: https://github.com/apache/openjpa/pull/290
https://issues.apache.org/jira/browse/OPENJPA-3069 Builds on #289 (its two commits are included here; the diff gets smaller once #289 is merged). ATR checks the release archives with its own rules: the ASF header word for word, the "developed at The Apache Software Foundation" sentence in NOTICE, and RAT with its own defaults, reading exclusions only from a `.rat-excludes` at the top of the archive, not from pom.xml. Similar to apache/storm#9263. 1. License headers: 74 files now carry the standard ASF header (47 openbooks classes with the short Apache-2.0 boilerplate, 9 test SQL files with a one-line header, 8 test classes with a corrupted header line, 6 JAXB generated test classes without one, and a few others). Nothing after the leading comment changed. 2. NOTICE: "developed by" -> "developed at". The NOTICE files with the schema paragraph also mention the Oracle JPA 2.1/2.2 and Jakarta Persistence 3.x schemas. 3. LICENSE: all LICENSE files that cover the schemas list the same 13 schemas and contain every license text they name (EPL 2.0 was missing in three). openjpa-project/LICENSE had the Apache License twice. 4. RAT: new `.rat-excludes` with the patterns of the pom's RAT config. The source assembly now includes it (dot files were excluded) and leaves out the generated dependency-reduced-pom.xml files, which the old pattern never matched. 5. Module jars: META-INF/LICENSE and NOTICE in the jars were missing the Apache License and the ASF notice (also in 4.1.1), because the module .vm files replaced the template of the Apache resource bundle instead of being appended. They are now appended. `<organization><name>` is "The Apache Software Foundation", which also changes Bundle-Vendor. Separate commit. Checked with a local replica of ATR's header and NOTICE/LICENSE checks and RAT 0.18 with ATR's command line: source tree and source zip 74 -> 0 header failures, RAT 0 unapproved / 0 unknown, binary zip and module jars pass. mvn validate and the tests using the changed SQL/JAXB files pass. Not verified: the sqlActionRefresh IT (not runnable offline), and the binary zip with docs, which probably needs `docs/**` in ATR's RAT source excludes setting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
