rzo1 commented on code in PR #297:
URL: https://github.com/apache/openjpa/pull/297#discussion_r4525750231
##########
openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/MySQLDictionary.java:
##########
@@ -56,6 +58,27 @@
public class MySQLDictionary
extends DBDictionary {
+ /**
Review Comment:
Agreed, MySQL and MariaDB duplicate a lot of each other. I will do that in a
follow-up PR, so this fix stays small: a common superclass for the two
dictionaries, and the MySQL 8 reserved words (e.g. `RANK`) that
`MySQLDictionary` does not know yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
