rzo1 commented on PR #305:
URL: https://github.com/apache/openjpa/pull/305#issuecomment-6793098555
No human can review this :P ;D – 1162 files, +16853/−9391. Luckily I didn't
have to do it alone, and it seems you didn't either (OpenRewrite says hi:
`{@link Assertions#setUp}` 😄).
Still found a few things worth a look before it leaves draft:
- `SliceTestCase`: `@BeforeEach` on `setUp(Object...)` can't be resolved by
Jupiter, so every slice test errors.
- 8 classes override `setUp()`/`tearDown()` with only `@Override`
(TestTemporalCoalesce, TestCompoundRefColumn, TestStringLiteralValues,
TestRemoteCommit*, TestReplicationConnection, TestDaytrader), so neither the
override nor the base lifecycle runs. Mostly tests that came in with the latest
master merges.
- `KubernetesTCPRemoteCommitProviderTest` lost its `@Rule` (mock server
never starts), and `OpenJpaEnhancerMojoTest` never calls
`AbstractMojoTestCase.setUp()`.
- `TestPessimisticLocks.dict` is never assigned anymore, and
`testCommon(...)` in the `TestMixedLockManager*Basic` classes got a `@Test`.
- `DynamicEnhancementSuite` is empty now, so the `test-dynamic-enhancer`
profile runs 0 tests.
- `@Timeout(10)` in `TestTCPRemoteCommitProvider` should use `threadMode =
SEPARATE_THREAD`.
Happy to send fixes as a PR against your branch if that helps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
