[
https://issues.apache.org/jira/browse/OPENJPA-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18142959#comment-18142959
]
ASF subversion and git services commented on OPENJPA-3007:
----------------------------------------------------------
Commit 1d8a8e9944760a75f5631b9853bebc62c431f150 in openjpa's branch
refs/heads/OPENJPA-3007 from Maxim Solodovnik
[ https://gitbox.apache.org/repos/asf?p=openjpa.git;h=1d8a8e994 ]
[OPENJPA-3007] best practices
> Junit6 should be used for tests
> -------------------------------
>
> Key: OPENJPA-3007
> URL: https://issues.apache.org/jira/browse/OPENJPA-3007
> Project: OpenJPA
> Issue Type: Improvement
> Components: build / infrastructure
> Affects Versions: 4.1.1
> Reporter: Maxim Solodovnik
> Assignee: Maxim Solodovnik
> Priority: Major
> Fix For: 4.3.0
>
>
> - Junit6 should be used for tests
> - various
> {code}
> <dependencies>
> <dependency>
> <groupId>junit</groupId>
> <artifactId>junit</artifactId>
> </dependency>
> </dependencies>
> {code}
> blocks (added at 0e8b4abfb04d02d9bf9a862b14b8afadc88f3445) should be removed
> - {{TestEmbeddableCriteria.countTestMethods}} need to be carefully migrated
> - various {{assertSQL}}, {{assertNotSQL}}, {{assertAllSQL*}},
> {{assertSQLFragnments}} need to be unified
> - Tests like
> {{openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/conversion/TestConvertedInPlaceChange.java}}
> {{testElementOfConvertedListRestoredOnRollback}} need to be converted to
> parametrized
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
