solomax commented on code in PR #303:
URL: https://github.com/apache/openjpa/pull/303#discussion_r4548009534
##########
openjpa-persistence/src/main/java/org/apache/openjpa/persistence/AnnotationPersistenceMetaDataParser.java:
##########
@@ -1985,7 +1985,8 @@ private void parseSequenceGenerator(AnnotatedElement el,
String seq = gen.sequenceName();
// JPA spec: when sequenceName is not specified, use the generator name
// as the database sequence name
- if (StringUtil.isEmpty(seq)) {
+ boolean defaultSeq = StringUtil.isEmpty(seq);
Review Comment:
this change seems to be redundant
##########
openjpa-persistence/src/main/java/org/apache/openjpa/persistence/AnnotationPersistenceMetaDataParser.java:
##########
@@ -1985,7 +1985,8 @@ private void parseSequenceGenerator(AnnotatedElement el,
String seq = gen.sequenceName();
// JPA spec: when sequenceName is not specified, use the generator name
// as the database sequence name
- if (StringUtil.isEmpty(seq)) {
+ boolean defaultSeq = StringUtil.isEmpty(seq);
Review Comment:
this change seems to be redundant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]