On Jun 18, 2010, at 8:45 AM, ext Bart van den Eijnden wrote: > Hi list, > > currently Renderer::eraseGeometry is not given the featureId, while it is > known in the calling function. Is there any specific reason for this? All > other functions, like drawGeometry do get the featureId.
At one point, we tried to make it such that the geometry methods were not working with/knowing about features at all. This may just be a remnant of that now-abandoned approach. As a side note, looking at this section of code is sort of funny: 3545 crschmidt * featureId - {<String>} 1811 pagameba */ 3065 tschaub drawGeometry: function(geometry, style, featureId) {}, 2641 euzuro The history of this particular section of code is long and varied. :) > In my custom Renderer I needed to create a lookup between the geometry id and > the feature id, just like in the Canvas renderer, but this seems like > overkill to me. I can agree this seems unnecessary. > Why not also pass the featureId to eraseGeometry, so no lookup is needed? I don't have a problem with that. > See also: > http://trac.openlayers.org/ticket/2693 > > TIA. > > Best regards, > Bart > _______________________________________________ > Dev mailing list > Dev@openlayers.org > http://openlayers.org/mailman/listinfo/dev Regards, -- Christopher Schmidt Nokia _______________________________________________ Dev mailing list Dev@openlayers.org http://openlayers.org/mailman/listinfo/dev