Finally was able to merge! Thanks! Hopefully can continue testing/fixing this module :)
On 29 June 2014 17:54, Maxim Solodovnik <[email protected]> wrote: > Great, thanks! > will merge it asap :) > > > On 29 June 2014 17:47, Bogdanov Andrey <[email protected]> wrote: > >> It will not cut commands while sending. The parameter only limits chunk >> size but all commands there will be sended as a whole. >> >> >> Sun, 29 Jun 2014 16:52:26 +0700 от Maxim Solodovnik <[email protected] >> >: >> > >> > Hello Andrey, >> > >> > Thanks for the quick fix :) >> > I have only one question: Is it safe to set buffer in bytes? >> > Is it possible command being send will be truncated? >> > >> > >> > On 28 June 2014 01:42, Bogdanov Andrey < [email protected] > wrote: >> > >Hi Maxim, >> > > >> > >I've just push changes to the repository >> https://github.com/bay73/whiteboard.git >> > >Now linkWebSocket method accepts two additional parameter: bufferSize >> and bufferTimeout >> > > >> > >bufferSize parameter shows the size of buffer in bytes before >> posting changes >> > >bufferTimeout shows the timeout (in milliseconds) - in this case >> changes will be posted even if size limit is not exceeded. >> > > >> > >So now you can call the method like this: >> > >whiteboard.linkWebSocket(url, 10000, 500); >> > > >> > >This parameters also can be set in runtime. For example: >> > >whiteboard.properties.ws.bufferSize = 20000 >> > >whiteboard.properties.ws.bufferTimeout = 1000 >> > > >> > > >> > >Best regards, >> > >Andrey Bogdanov >> > > >> > > > > -- > WBR > Maxim aka solomax > -- WBR Maxim aka solomax
