you need to enable client debug mode and check what is going on
the "oninit diff" you are referring can not fix anything
these 2 code blocks are equivalent, I just prefer second one due to it is
more strict and compiler might help you to find the typo
On Fri, Sep 2, 2016 at 12:22 AM, Coscend@OM <om.insig...@coscend.com> wrote:
> Dear Developers,
>
> The original issue (OM-1433) with in-built toolbar icons disappearing when
> vertical was due to Oninit handler's visibility attribute in
> mainToolsPanel.lzx. Any ideas for us to resolve the same issue with CUSTOM
> toolbars would be appreciated.
>
> <mainToolsPanelItem name="clipart" modi="clipart" labelid="1323" >
> <handler name="oninit">
> - if (this["_bgIcon"]) {
> - this._bgIcon.setAttribute("visibility","hidden");
> - }
> + if (this["_bgIcon"]) {
> + this._bgIcon.setAttribute("visible", false);
> + }
>
> Thank you.
> Sincerely,
>
> Hemant K. Sabat
> Coscend Communications Solutions
> Web site: www.Coscend.com
> ------------------------------------------------------------------
> CONFIDENTIALITY NOTICE: See 'Confidentiality Notice Regarding E-mail
> Messages from Coscend Communications Solutions' posted at:
> http://www.Coscend.com/Terms_and_Conditions.html
> -----Original Message-----
> From: Coscend@OM [mailto:om.insig...@coscend.com]
> Sent: Thursday, September 1, 2016 11:51 AM
> To: dev@openmeetings.apache.org
> Subject: RE: Whiteboard Tools Panel (CUSTOM) Broken
>
> Dear Developers,
>
> Any thoughts on how to resolve these issues:
> (A) issue [1] for 5 CUSTOM toolbars we have added. Icons disappear when
> the toolbars are made vertical (right / left).
> (B) Some of these custom toolbars stick to each other while dragging
> anyone of them.
> The ORIGINAL toolbar from source code does NOT have these issues.
> -------
> [1] WB vertical tools panel is broken: https://issues.apache.org/
> jira/browse/OPENMEETINGS-1433
>
> Thank you.
>
> Sincerely,
>
> Hemant K. Sabat
>
> Coscend Communications Solutions
> Web site: www.Coscend.com
> ------------------------------------------------------------------
> CONFIDENTIALITY NOTICE: See 'Confidentiality Notice Regarding E-mail
> Messages from Coscend Communications Solutions' posted at:
> http://www.Coscend.com/Terms_and_Conditions.html
>
> -----Original Message-----
> From: Coscend@OM [mailto:om.insig...@coscend.com]
> Sent: Wednesday, August 31, 2016 12:07 PM
> To: dev@openmeetings.apache.org
> Subject: RE: Whiteboard Tools Panel (CUSTOM) Broken
>
> Dear Sebastian,
>
> Below are:
> 1. The data flow across files.
> 2. sample snippet from mainToolsPanel.lzx---this sets up the context
> fixedFileExplorerWhiteboard.lzx ----perhaps this is the cause of the issue
>
> Thank you.
>
> -----
> Data flow
> -----
> Application.properties.xml: contains label IDs of the different tools in
> a toolbar.
> theme.xml: png/jpg filenames of thumbnails
> fixedFileExplorerWhiteBoard.lzx: connects the tools to whiteboard
> mainToolsPanel.lzx: methods for onclick activation of the tools
>
> --------
> Sample Snippet
> --------
> A. mainToolsPanel.lzx
> 1. Defined the menuIconbar class: XYZMenuIconBar
> This class contains the instances of Tools class: <mainToolsPanelItem>
> for each tool
> Each such tool is linked to a <resource> entry in theme.xml
>
> 2. Defined the class XYZToolsTopPanel similar to existing class 3.
> Defined the class XYZToolsTopPanelPointer similar to existing class 4.
> Defined the class XYZToolsLeftPanelPointer similar to existing class
>
>
> B. Instantiate toolbar inside whiteboard fixedFileExplorer.lzx:
>
> <XYZToolsTopPanel x="80" y="105" name="_XYZToolsPanel"
> visible="${ ((canvas.ismoderator || canvas.isAllowedToDraw) ?
> true : false ) }"/>
>
> <XYZToolsLeftPanelPointer y="20" name="_XYZToolsLeftPanelPointer"
> visible="${ (parent.parent.restricted) ? false :
> (((canvas.ismoderator) ? false :
> ((canvas.isAllowedToDraw) ? false : true ))) }"/>
>
> Sincerely,
>
> Hemant K. Sabat
>
> Coscend Communications Solutions
> Web site: www.Coscend.com
> ------------------------------------------------------------------
> CONFIDENTIALITY NOTICE: See 'Confidentiality Notice Regarding E-mail
> Messages from Coscend Communications Solutions' posted at:
> http://www.Coscend.com/Terms_and_Conditions.html
>
>
> -----Original Message-----
> From: Coscend@OM [mailto:om.insig...@coscend.com]
> Sent: Tuesday, August 30, 2016 11:42 PM
> To: dev@openmeetings.apache.org
> Subject: RE: Whiteboard Tools Panel (CUSTOM) Broken
>
> Dear Sebastian,
>
> We will post the code snippet tomorrow AM US time by collecting it from
> the following files.
>
> In the meantime, to vet your appetite:
>
> Application.properties.xml: contains label IDs of the different tools in
> a toolbar.
> theme.xml: png/jpg filenames of thumbnails
> fixedFileExplorerWhiteBoard.lzx: connects the tools to whiteboard
> mainToolsPanel.lzx: methods for onclick activation of the tools
>
> Thank you.
>
> Sincerely,
>
> Hemant K. Sabat
>
> Coscend Communications Solutions
> Web site: www.Coscend.com
> ------------------------------------------------------------------
> CONFIDENTIALITY NOTICE: See 'Confidentiality Notice Regarding E-mail
> Messages from Coscend Communications Solutions' posted at:
> http://www.Coscend.com/Terms_and_Conditions.html
>
>
> -----Original Message-----
> From: seba.wag...@gmail.com [mailto:seba.wag...@gmail.com]
> Sent: Tuesday, August 30, 2016 11:10 PM
> To: dev <dev@openmeetings.apache.org>
> Cc: om.insig...@coscend.com
> Subject: Re: Whiteboard Tools Panel (CUSTOM) Broken
>
> @ Hemant do you have a sample snippet of how you use the toolbar ?
>
> 2016-08-31 15:35 GMT+12:00 Maxim Solodovnik <solomax...@gmail.com>:
>
> > If I remember correctly original issue was caused by multiple WB on
> > top of each other I can't tell you what is wrong with your code :(
> >
> > On Wed, Aug 31, 2016 at 9:43 AM, seba.wag...@gmail.com <
> > seba.wag...@gmail.com> wrote:
> >
> > > If I can remember correctly we added the "stickiness" but you can
> > > disable it with a property.
> > >
> > > Thanks,
> > > Sebastian
> > >
> > > 2016-08-31 7:55 GMT+12:00 Coscend@OM <om.insig...@coscend.com>:
> > >
> > > > Dear OpenMeetings Developers,
> > > >
> > > >
> > > >
> > > > We added 5 CUSTOM toolbars to the conference rooms. We are facing
> > > >
> > > > (1) issue [1] for the custom toolbars.
> > > >
> > > > (2) Some of these custom toolbars stick to each other while
> dragging
> > > > anyone of them.
> > > >
> > > >
> > > >
> > > > The ORIGINAL toolbar from source code does NOT have these issues.
> > > >
> > > >
> > > >
> > > > Could you please give us pointers to the CAUSE of this issue?
> > > >
> > > > -------
> > > >
> > > > [1] WB vertical tools panel is broken:
> > > > https://issues.apache.org/jira/browse/OPENMEETINGS-1433
> > > >
> > > > Drag CUSTOM tools panel to the right/left side of the WB
> > > > Result: panel contains no icons
> > > >
> > > >
> > > >
> > > > Thank you.
> > > >
> > > >
> > > >
> > > > Sincerely,
> > > >
> > > >
> > > >
> > > > Hemant K. Sabat
> > > >
> > > >
> > > >
> > > > Coscend Communications Solutions
> > > >
> > > > Web site: <http://www.coscend.com/> www.Coscend.com
> > > >
> > > > ------------------------------------------------------------------
> > > >
> > > > CONFIDENTIALITY NOTICE: See 'Confidentiality Notice Regarding
> > > > E-mail Messages from Coscend Communications Solutions' posted at:
> > > > <http://www.coscend.com/Terms_and_Conditions.html>
> > > > http://www.Coscend.com/Terms_and_Conditions.html
>
>
>
>
> -----
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 2016.0.7752 / Virus Database: 4649/12926 - Release Date: 09/01/16
>
>
>
--
WBR
Maxim aka solomax
