On Fri, 17 Apr 2020 at 03:25, [email protected] <[email protected]> wrote:
> Yeah cool I will try to read that and incorporate. > > Out of https://github.com/Kurento/kurento-tutorial-java > => Which ones are more closest to our conference room ? > I would say kurento-hello-world-recording <https://github.com/Kurento/kurento-tutorial-java/tree/master/kurento-hello-world-recording> - for recording kurento-one2many-call <https://github.com/Kurento/kurento-tutorial-java/tree/master/kurento-one2many-call> - for any room activity + my own observations and solutions :) > > I took the flow from a OpenMeetings presentation room. So with user > initiating the Media Broadcast. > => I couldn't see the trigger for automatically doing init of the > audio/video in the conference room. Is it the same flow I assume? But where > is the trigger to automatically start audio/video ? > https://github.com/apache/openmeetings/blob/master/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/sidebar/RoomSidebar.java#L90 > > I would also like to add a section with security config params. I noticed > some fields for username/password. > => Can you point out some configuration values that can be adjusted ? > Is it about TURN server? > > Other flows for later: > - Networking and TRUN/STUN > - Lost network and bandwidth issues > > I think referencing those will be a good starting point to discuss. > > Cheers > Seb > > On Fri, 17 Apr 2020 at 05:16, Maxim Solodovnik <[email protected]> > wrote: > >> >> Hello Sebastian, >> >> You did great job :) >> >> Here are some comments: >> 1) First diagram: "webRTC wss://$server:433" I would say right now it >> most probably "ws://KMS:8888" >> In fact server and client are send iceCandidates back and forth trying to >> find network interface and port on both ends >> If no direct connection is available STUN/TURN server tries to help >> in case of demo-next direct connection to KMS is impossible so coturn do >> the job >> >> 2) there are several flows >> 1) Audio/Video test setup record >> 2) Audio/Video test setup playback >> 3) Audio/Video broadcast in room (recording endpoint can be >> added/removed if necessary) >> In this case new WebRTC endpoint is created >> 4) Audio/Video playback in room >> In this case new WebRTC endpoint is connected to the sender (so >> all can be dropped on broadcast stop) >> >> In every flow websocket messages are sent to KurentoHandler >> StreamProcessor and TestStreamProcessor were created and separated to >> make KurentoHandler more readable :) >> >> TestStreamProcessor is more or less covered with tests [1] >> >> I'm not sure I can add any links >> I have created this flow by debugging various examples from here >> https://github.com/Kurento/kurento-tutorial-java >> >> Recently I found this flow is not bullet-proof and web-rtc connection >> might not be established even if no errors were reported >> This is why we get lots of emails like "I only can see my own video" >> [2] should improve situation >> >> According to security: we are using secured channel for WS messages >> KMS can be secured by setting up HTTPS proxy (in this case port 8888 will >> be accessible at 443) >> Not sure what else can be done here >> >> Current KWatchDog seems to work .... >> >> I would like to get feedback from you :) >> What can be improved? :)) >> >> [1] >> https://sonarcloud.io/code?id=apache_openmeetings&selected=apache_openmeetings%3Aopenmeetings-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fopenmeetings%2Fcore%2Fremote%2FTestStreamProcessor.java >> [2] >> https://github.com/apache/openmeetings/blob/master/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-video.js#L118 >> >> >> On Thu, 16 Apr 2020 at 04:42, [email protected] < >> [email protected]> wrote: >> >>> Happy to take comments and update the diagram as we go. >>> >>> On Thu, 16 Apr 2020 at 09:39, [email protected] < >>> [email protected]> wrote: >>> >>>> Hi Maxim and Devs! >>>> >>>> could you please review: >>>> >>>> https://cwiki.apache.org/confluence/display/OPENMEETINGS/OpenMeetings+Session+Initialisation+and+Security >>>> >>>> And the first flow that I added at: >>>> >>>> https://cwiki.apache.org/confluence/display/OPENMEETINGS/OpenMeetings+Session+Initialisation+and+Security#OpenMeetingsSessionInitialisationandSecurity-CreateVideoStream >>>> >>>> Questions: >>>> >>>> - Could you please review if my diagram misses major functionality ? >>>> - Could you please point out where my diagram ends around >>>> iceCandidate if that is the actual end / successful created media >>>> stream? >>>> Or did I finish too early ? >>>> - Could you please add some more links around supporting material >>>> for different parts of the flow ? >>>> - Any considerations to secure the stream/connection that should be >>>> added ? >>>> >>>> >>>> Thanks! >>>> Seb >>>> -- >>>> Sebastian Wagner >>>> https://twitter.com/#!/dead_lock >>>> [email protected] >>>> >>> >>> >>> -- >>> Sebastian Wagner >>> https://twitter.com/#!/dead_lock >>> [email protected] >>> >> >> >> -- >> Best regards, >> Maxim >> > > > -- > Sebastian Wagner > https://twitter.com/#!/dead_lock > [email protected] > -- Best regards, Maxim
