Yeah that makes sense. I will have a look over the next few days Cheers! Seb
Sebastian Wagner Director Arrakeen Solutions, OM-Hosting.com http://arrakeen-solutions.co.nz/ https://om-hosting.com - Cloud & Server Hosting for HTML5 Video-Conferencing OpenMeetings <https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url> <https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url> On Wed, 15 Jun 2022 at 16:55, Maxim Solodovnik <solomax...@gmail.com> wrote: > On Wed, 15 Jun 2022 at 11:51, seba.wag...@gmail.com > <seba.wag...@gmail.com> wrote: > > > > Yeah I would benefit. It would make customisation of MediaServer > > integration easier. > > OK, let's do it :) > I would start with extracting new module "as-is" > > then upgrading to 4.18 in separate PR > > > > > I'm happy to do it and put up a PR. But rather check first here before > > doing it. The technicalities of creating another module may spark other > > discussions. So rather agree here first. > > > > Thanks > > Seb > > > > Sebastian Wagner > > Director Arrakeen Solutions, OM-Hosting.com > > http://arrakeen-solutions.co.nz/ > > https://om-hosting.com - Cloud & Server Hosting for HTML5 > > Video-Conferencing OpenMeetings > > < > https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url > > > > < > https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url > > > > > > > > On Wed, 15 Jun 2022 at 16:46, Maxim Solodovnik <solomax...@gmail.com> > wrote: > > > > > On Wed, 15 Jun 2022 at 11:40, seba.wag...@gmail.com > > > <seba.wag...@gmail.com> wrote: > > > > > > > > Hm, looking at the packages in openmeetings-core: > > > > > > > > https://github.com/apache/openmeetings/tree/master/openmeetings-core/src/main/java/org/apache/openmeetings/core > > > > > > > > There are a lot of non KMS related packages in it. > > > > > > you are definitely right :) > > > > > > > > > > > While actually it should be just the -remote folder: > > > > > > > > https://github.com/apache/openmeetings/tree/master/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote > > > > > > > > Potentially there is some other Streaming reference somewhere but > those > > > > folder might be better in something like *openmeetings-kms* or > > > > *openmeetings-mediaserver* or something like that. > > > > > > I'm not a big fun of such refactoring until it will be needed > > > Will you benefit from such refactoring? > > > > > > If not I would postpone it > > > > > > > > > > > Thanks > > > > Seb > > > > > > > > Sebastian Wagner > > > > Director Arrakeen Solutions, OM-Hosting.com > > > > http://arrakeen-solutions.co.nz/ > > > > https://om-hosting.com - Cloud & Server Hosting for HTML5 > > > > Video-Conferencing OpenMeetings > > > > < > > > > https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url > > > > > > > > < > > > > https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url > > > > > > > > > > > > > > > > On Wed, 15 Jun 2022 at 01:57, Maxim Solodovnik <solomax...@gmail.com > > > > > wrote: > > > > > > > > > Hello Seb, > > > > > > > > > > from mobile (sorry for typos ;) > > > > > > > > > > > > > > > On Sun, Jun 12, 2022, 03:51 seba.wag...@gmail.com < > > > seba.wag...@gmail.com> > > > > > wrote: > > > > > > > > > > > The KMS project has some pre-info for KMS 6.18: > > > > > > > > > > > > > > > https://doc-kurento.readthedocs.io/en/latest/project/relnotes/v6_18_0.html > > > > > > > > > > > > It talks about breaking changes, e.g. renamed API objects: > > > > > > > > > > > > > > > > > > > > > https://doc-kurento.readthedocs.io/en/latest/project/relnotes/v6_18_0.html#deprecated-renamed-api-methods > > > > > > > > > > > > > > > > > I also heard about upcoming release at kms google-group > > > > > > > > > > > > > > > > > > > > > > Maybe we could aim for v7.0.0 of OpenMeetings to migrate to KMS > 6.18 > > > + > > > > > > JDK17 source code level as its main features? > > > > > > > > > > > > > > > > I'll check what wad changed :) > > > > > 4.18 has native support of Ubuntu 20.04 (no support for 22.04 yet) > > > > > So this might be good idea > > > > > > > > > > > > > > > > > > > > > > I'm not too sure when is a good time to start to migrate to KMS > > > > > > 6.18-SNAPSHOT in the OpenMeetings master branch. Not sure if the > API > > > is > > > > > > stable enough yet. But it looks like docs are available already. > > > > > > > > > > > > It may also be an opportunity to separate the KMS relevant > classes & > > > > > > functionality into a separate maven module in the OpenMeetings > > > project. A > > > > > > separated module would make customisation easier as well as > > > separating > > > > > > OpenMeetings core from KMS relevant details. > > > > > > > > > > > > > > > > It is already in separated module :) > > > > > Openmeetings-core > > > > > I would wait with further separation until we will have need for it > > > > > > > > > > Or maybe you will benefit of it? > > > > > > > > > > > > > > > > Another example that becomes easier is if somebody wants to > build a > > > Media > > > > > > Server integration to another type of Media Server. E.g. > OpenVidu, or > > > > > some > > > > > > other fork of KMS. Having the KMS relevant code into its own > maven > > > > > module, > > > > > > would be a good first step to enable it. > > > > > > > > > > > > Thanks > > > > > > Seb > > > > > > > > > > > > Sebastian Wagner > > > > > > Director Arrakeen Solutions, OM-Hosting.com > > > > > > http://arrakeen-solutions.co.nz/ > > > > > > https://om-hosting.com - Cloud & Server Hosting for HTML5 > > > > > > Video-Conferencing OpenMeetings > > > > > > < > > > > > > > > > > > > > > > https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url > > > > > > > > > > > > > < > > > > > > > > > > > > > > > https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > Best regards, > > > Maxim > > > > > > > -- > Best regards, > Maxim >
