Re: svn commit: r1448517 - in /opennlp/trunk/opennlp-tools/src: main/java/opennlp/tools/namefind/RegexNameFinder.java test/java/opennlp/tools/namefind/RegexNameFinderTest.java

[Jörn Kottmann]

On 02/21/2013 06:34 AM, jko...@apache.org wrote:
-  public RegexNameFinder(Pattern patterns[]) {
+  public RegexNameFinder(Pattern patterns[], String type) {
      if (patterns == null || patterns.length == 0) {
        throw new IllegalArgumentException("patterns must not be null or 
empty!");
      }
  
      mPatterns = patterns;
+    sType = type;
    }
  
+  public RegexNameFinder(Pattern patterns[]) {
+    if (patterns == null || patterns.length == 0) {
+      throw new IllegalArgumentException("patterns must not be null or 
empty!");
+    }
+
+    mPatterns = patterns;
+    sType = null;
+  }
+

Thanks for fixing this James. If I am not mistaken, then the second 
constructor could just call the
first one and pass null for the type right? Then we do not need to 
duplicate the init code.

Jörn